bg--transparent class added #194
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not perfect but should work for most/better than not having defaults
# Conflicts: # css/tachyons.min.css
|
Hey @hongkonggong - All Pull Requests for the main repo need to be made into the individual modules, as those get dynamically copied over based on the declared module version in the package.json. I've gone ahead and updated the tachyons-skins repo and then updated the main project. Thanks for pointing out missing this! |
|
Oh my bad, thanks for correcting me on that (and making the update)! |
|
Nah it's not your bad, it's in the contributing guidelines in the readme but it is buried. And it's a different workflow than most other projects so it's pretty weird. Wish it was easier to give 'github credit' when I have to make the patch manually myself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #193