Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect excludes in zappa_settings #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

colinhoernig
Copy link

Fixes excludes in settings so it's respected.

in zappa_settings.json

    "exclude": [
      "boto3",
      "botocore",
      "mypy",
      "pytest",
      "bandit",
      "black"
    ],
tackle-public-api on  ckh/ENG-3616/exclude-dev-deps [$!] via 🐍 tackle-public-api 
❯ zappa package dev
Important! A new version of Zappa is available!
Upgrade with: pip install zappa --upgrade
Visit the project page on GitHub to see the latest changes: https://github.com/Zappa/Zappa
Calling package for stage dev..
Warning! Your project and virtualenv have the same name! You may want to re-create your venv with a new name, or explicitly define a 'project_name', as this may cause errors.
Downloading and installing dependencies..
 - typed-ast==1.4.3: Using locally cached manylinux wheel
 - regex==2021.4.4: Using locally cached manylinux wheel
 - pyyaml==5.4.1: Downloading
100%|████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 662k/662k [00:00<00:00, 33.4MB/s]
 - pytest==6.1.2: ignored, skipping...
 - pydantic==1.8.2: Using locally cached manylinux wheel
 - pip==21.0.1: ignored, skipping...
 - mypy==0.812: ignored, skipping...
 - markupsafe==2.0.1: Downloading
100%|██████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████████| 30.6k/30.6k [00:00<00:00, 8.07MB/s]
 - lazy-object-proxy==1.6.0: Using locally cached manylinux wheel
 - cryptography==3.4.7: Using locally cached manylinux wheel
 - coverage==5.5: Using locally cached manylinux wheel
 - cffi==1.14.5: Using locally cached manylinux wheel
 - botocore==1.20.79: ignored, skipping...
 - boto3==1.17.79: ignored, skipping...
 - black==20.8b1: ignored, skipping...
 - bandit==1.7.0: ignored, skipping...
Packaging project as zip.
Package created: tacklepublicapi-dev-1626815151.zip (42.7MiB)

@colinhoernig colinhoernig changed the title fix: ignore excludes fix: respect excludes in zappa_settings Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant