Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.0.0 #6

Merged
merged 10 commits into from
Jul 12, 2024
Merged

v0.0.0 #6

merged 10 commits into from
Jul 12, 2024

Conversation

ohhamma
Copy link
Contributor

@ohhamma ohhamma commented Jul 12, 2024

πŸ“Œ μ—°κ΄€λœ 이슈

πŸ“ μž‘μ—… λ‚΄μš©

  • μŠ€ν”„λ§ ν™˜κ²½ μ„ΈνŒ…
  • PR ν…œν”Œλ¦Ώ μΆ”κ°€
  • 컀밋 ν…œν”Œλ¦Ώ 적용
  • 도컀 ν™˜κ²½ μ„ΈνŒ…
  • Github Actions μ„ΈνŒ…

🌳 μž‘μ—… 브랜치λͺ…

  • develop

πŸ“Έ μŠ€ν¬λ¦°μƒ· (선택)

πŸ’¬ 리뷰 μš”κ΅¬μ‚¬ν•­ (선택)

ohhamma and others added 10 commits July 11, 2024 16:55
@ohhamma
KL-14/chore: set up spring
52fd2e1
@idealflower-k
KL-15/docs: add git commit template
9903f35
@ohhamma
KL-17/docs: add PR template
3548674
@ohhamma
Merge pull request #1 from taco-official/KL-14/be-μŠ€ν”„λ§-ν™˜κ²½-μ„€μ •
a0735c7 
chore(KL-14): set up spring
@idealflower-k
Merge pull request #2 from taco-official/KL-17/pr-ν…œν”Œλ¦Ώ-μΆ”κ°€
03ee4dc 
docs(KL-17): add PR template
@idealflower-k
Merge pull request #3 from taco-official/KL-15/be-git-컀밋-ν…œν”Œλ¦Ώ-적용
4ebb712 
docs(KL-25): add git commit template
@ohhamma
KL-54/docs: set docker environment
4bf308d 
- docker compose file μž‘μ„±
- spring dockerfile μž‘μ„±
- makefile μž‘μ„±
@ohhamma
Merge pull request #4 from taco-official/KL-54/λ„μ»€ν™˜κ²½-μ„ΈνŒ…
1bcbe74 
docs(KL-54): set docker environment
@idealflower-k
KL-55/docs: add makefile workflow
4528cd5 
- makefile을 μ‚¬μš©ν•˜λŠ” github action workflowλ₯Ό μΆ”κ°€ν–ˆμŠ΅λ‹ˆλ‹€.
@idealflower-k
Merge pull request #5 from taco-official/KL-55/github-actions-μ„ΈνŒ…
f6d154e 
docs(KL-55): add makefile workflow
@ohhamma ohhamma added the πŸ“ Docs λ¬Έμ„œ μž‘μ„± 및 μˆ˜μ • label Jul 12, 2024
@ohhamma ohhamma self-assigned this Jul 12, 2024
@ohhamma ohhamma removed the πŸ“ Docs λ¬Έμ„œ μž‘μ„± 및 μˆ˜μ • label Jul 12, 2024
idealflower-k
idealflower-k approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@idealflower-k idealflower-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

와 ν”„λ‘œμ νŠΈμ˜ μ‹œμž‘μ„ ν•˜κ²Œλ˜μ–΄μ„œ μ’‹μŠ΅λ‹ˆλ‹€!
ν™”μ΄νŒ…!

min3m
min3m approved these changes Jul 12, 2024
View reviewed changes
Copy link

@min3m min3m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.0.0 버전 κ°€μŠ΄μ΄ μ›…μž₯ν•΄μ§‘λ‹ˆλ‹€.
κ°œλ°œν™˜κ²½ μ„€μ •κ³Ό κΉƒν—™ μ•‘μ…˜ μ„€μ •, 컀밋 ν…œν”Œλ¦Ώκ³Ό PR ν…œν”Œλ¦Ώ μ˜¬λ €μ£Όμ‹ κ±° 잘 μ‚¬μš©ν•΄ 보도둝 ν•˜κ² μŠ΅λ‹ˆλ‹€!
μ—΄μ‹¬νžˆ μ‹œμž‘ ν•΄λ΄…μ‹œλ‹€μš”

@sayoonnn sayoonnn closed this Jul 12, 2024
@sayoonnn sayoonnn reopened this Jul 12, 2024
@ohhamma ohhamma reopened this Jul 12, 2024
sayoonnn
sayoonnn approved these changes Jul 12, 2024
View reviewed changes
Copy link

@sayoonnn sayoonnn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

평가 μ½”λ©˜νŠΈ

νŒ€ @ohhamma, @idealflower-k,

초기 ν”„λ‘œμ νŠΈ μ„€μ • μž‘μ—…μ— λŒ€ν•΄ 수고 λ§ŽμœΌμ…¨μŠ΅λ‹ˆλ‹€. μŠ€ν”„λ§ ν™˜κ²½, 도컀, 그리고 Github Actionsλ₯Ό ν¬ν•¨ν•œ 기본적인 섀정듀이 잘 κ΅¬μ„±λœ κ²ƒμœΌλ‘œ λ³΄μž…λ‹ˆλ‹€. 이둜써 개발 ν™˜κ²½μ΄ 효과적으둜 쀀비됐닀고 μƒκ°ν•©λ‹ˆλ‹€.

λͺ‡ 가지 μ œμ•ˆ 사항:

  1. PR ν…œν”Œλ¦Ώκ³Ό 컀밋 ν…œν”Œλ¦Ώ μ μš©μ€ λͺ¨λ“  νŒ€μ›μ΄ μΌκ΄€λœ ν˜•μ‹μ„ μœ μ§€ν•  수 있게 도와쀄 κ²ƒμž…λ‹ˆλ‹€. λͺ¨λ“  νŒ€μ›μ΄ 이λ₯Ό 잘 λ”°λ₯΄κ³  μžˆλŠ”μ§€ ν™•μΈν•΄μ£Όμ„Έμš”.
  2. 도컀 ν™˜κ²½ μ„€μ •κ³Ό κ΄€λ ¨ν•˜μ—¬, ν–₯ν›„ μ„œλΉ„μŠ€ ν™•μž₯μ„± 및 μœ μ§€λ³΄μˆ˜ μΈ‘λ©΄μ—μ„œ λ¬Έμ„œν™”λ₯Ό μ’€ 더 κ°•ν™”ν•  ν•„μš”κ°€ μžˆμ–΄ λ³΄μž…λ‹ˆλ‹€. μ‚¬μš©λœ 도컀 컴포즈 파일과 μ£Όμš” 섀정에 λŒ€ν•œ μΆ”κ°€ λ¬Έμ„œν™”λ₯Ό ꢌμž₯ν•©λ‹ˆλ‹€.
  3. Github Actions μ„ΈνŒ…μ€ CI/CD νŒŒμ΄ν”„λΌμΈμ˜ μ΄ˆμ„μ„ λ‹€μ‘ŒμŠ΅λ‹ˆλ‹€. λ‹€λ§Œ, ν˜„μž¬ μ„€μ •λœ μ›Œν¬ν”Œλ‘œμš°κ°€ ν”„λ‘œμ νŠΈμ˜ ν•„μš”μ— μΆ©λΆ„νžˆ λΆ€μ‘ν•˜λŠ”μ§€ κ²€ν† ν•˜κ³ , ν•„μš”ν•œ ν…ŒμŠ€νŠΈ μŠ€ν¬λ¦½νŠΈλ‚˜ λΉŒλ“œ 슀크립트λ₯Ό μΆ”κ°€ν•˜λŠ” 것을 κ³ λ €ν•΄ λ³Ό μ‹œμ μž…λ‹ˆλ‹€.

μ „λ°˜μ μœΌλ‘œ ν›Œλ₯­ν•œ μ‹œμž‘μ„ λ³΄μ—¬μ£Όμ…¨μŠ΅λ‹ˆλ‹€. μ•žμœΌλ‘œλ„ μ΄λŸ¬ν•œ μ„Έμ‹¬ν•œ 관리가 μ§€μ†λœλ‹€λ©΄, ν”„λ‘œμ νŠΈμ˜ 기술적 ν† λŒ€κ°€ νŠΌνŠΌν•΄μ§ˆ κ²ƒμž…λ‹ˆλ‹€. κ³„μ†ν•΄μ„œ 쒋은 μž‘μ—… λΆ€νƒλ“œλ¦½λ‹ˆλ‹€!

42jeelee
42jeelee approved these changes Jul 12, 2024
View reviewed changes
Copy link

@42jeelee 42jeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

μ’‹μ•„μš”! κΉƒν—ˆλΈŒ μ•‘μ…˜ μ • - 말 μ‹ κΈ°ν•˜κ΅°μš”! πŸͺΏ !

@ohhamma ohhamma merged commit ddb3c6b into main Jul 12, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayoonnn sayoonnn sayoonnn approved these changes

@42jeelee 42jeelee 42jeelee approved these changes

@min3m min3m min3m approved these changes

@idealflower-k idealflower-k idealflower-k approved these changes

Assignees

@ohhamma ohhamma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ohhamma @idealflower-k @min3m @42jeelee @sayoonnn