Skip to content
This repository has been archived by the owner on Dec 12, 2024. It is now read-only.

fix[CI]: Added a new workflow and temporarily disabled i18n #83

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

novusnota
Copy link
Member

  • Added the test build CI step, which would run on PRs. And made the current deploy workflow only trigger on pushes to main, which only happens on merges as we have branch protection enabled (good!).

The main issue is still the same — Next.js (the underlying thing our doc theme uses) is very tough then it comes to combining i18n with static export as we do it now. That was the primary reason it took me whole 2 days to make it semi-right, but this time the fix is going to be very tough, because of this incompatibility. I'll try to look into it more, but at the moment I have a bold suggestion to move the docs to https://starlight.astro.build, as it's way easier to manage (I've tried already).

There's next-intl package, which may be nice with our setup, but will still require a ton of bike-shredding. In any case, I'll figure out a solution for keeping i18n and static exports.

@novusnota novusnota requested a review from anton-trunov March 4, 2024 20:31
@anton-trunov anton-trunov merged commit 85bc7ee into tact-lang:main Mar 5, 2024
2 checks passed
@novusnota novusnota deleted the mock-ci branch March 5, 2024 13:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants