Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix operations precendence #265

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Fix operations precendence #265

merged 3 commits into from
Apr 19, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Apr 18, 2024 •
edited
Loading

Closes #263

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich requested a review from anton-trunov April 18, 2024 10:52
@anton-trunov anton-trunov self-assigned this Apr 19, 2024
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 19, 2024
anton-trunov
anton-trunov requested changes Apr 19, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Let's just do a few small adjustments

CHANGELOG.md Outdated Show resolved Hide resolved
src/test/features/precendence.tact Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
src/test/feature-precendence.spec.ts Outdated Show resolved Hide resolved
@anton-trunov anton-trunov merged commit 88e3c38 into tact-lang:main Apr 19, 2024
3 checks passed
@anton-trunov
Copy link
Member

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov requested changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Precendence of bitwise operators is incorrect
2 participants
@Gusarich @anton-trunov