Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade and fix debugging feature #271

Merged
merged 14 commits into from
Apr 21, 2024
Merged

Upgrade and fix debugging feature #271

merged 14 commits into from
Apr 21, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented Apr 20, 2024 •
edited
Loading

Closes #260 and closes #270

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.3.0 milestone Apr 20, 2024
@Gusarich Gusarich requested a review from anton-trunov April 20, 2024 15:58
anton-trunov
anton-trunov requested changes Apr 21, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

stdlib/std/debug.tact Show resolved Hide resolved
src/abi/global.ts Outdated Show resolved Hide resolved
@anton-trunov anton-trunov self-assigned this Apr 21, 2024
anton-trunov
anton-trunov requested changes Apr 21, 2024
View reviewed changes
src/abi/global.ts Outdated Show resolved Hide resolved
@Gusarich
Copy link
Member Author

I've removed dump call from bugs.tact test because it wasn't checked there anyway and was just adding inconsistency in snapshots with this new debug update.

anton-trunov
anton-trunov previously approved these changes Apr 21, 2024
View reviewed changes
@anton-trunov anton-trunov merged commit b9c5abf into tact-lang:main Apr 21, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Incorrect typechecking for dump function dump should output its source code location information
2 participants
@Gusarich @anton-trunov