Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: switch from + to | for send modes #274

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix: switch from + to | for send modes #274

merged 3 commits into from
Apr 22, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Apr 22, 2024 •
edited
Loading

Closes #203

  • I have updated CHANGELOG.md
  • I have added unit tests to demonstrate the contribution is correctly implemented
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov merged commit d993edf into main Apr 22, 2024
3 checks passed
@anton-trunov anton-trunov deleted the switch-to-bitwise-or-for-sendmode branch April 22, 2024 08:07
@anton-trunov anton-trunov added this to the v1.3.0 milestone Apr 22, 2024
@anton-trunov anton-trunov self-assigned this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gusarich Gusarich Gusarich approved these changes

@novusnota novusnota Awaiting requested review from novusnota

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.0
Development

Successfully merging this pull request may close these issues.

Switch addition to bitwise 'or' for SendParameters's mode value
2 participants
@anton-trunov @Gusarich