Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log and log2 functions #342

Merged
merged 3 commits into from
May 17, 2024
Merged

Fix log and log2 functions #342

merged 3 commits into from
May 17, 2024

Conversation

Gusarich
Copy link
Member

Closes #340

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added the stdlib The Tact standard library label May 17, 2024
@Gusarich Gusarich requested a review from anton-trunov May 17, 2024 11:08
@Gusarich
Copy link
Member Author

@anton-trunov I've also decided to add error-throwing into log2 function for case with num = 0, because TVM doesn't throw in this case.

@Gusarich Gusarich added this to the v1.3.1 milestone May 17, 2024
@novusnota novusnota mentioned this pull request May 17, 2024
Merged
@anton-trunov anton-trunov merged commit e080f7f into tact-lang:main May 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees
No one assigned
Labels
stdlib The Tact standard library
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

log2 and log do not agree on negative numbers
2 participants
@Gusarich @anton-trunov