Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid shadowing static functions from global.ts #351

Merged
merged 3 commits into from
May 24, 2024
Merged

Forbid shadowing static functions from global.ts #351

merged 3 commits into from
May 24, 2024

Conversation

Gusarich
Copy link
Member

@Gusarich Gusarich commented May 23, 2024 •
edited
Loading

Closes #306

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.3.1 milestone May 23, 2024
novusnota
novusnota previously approved these changes May 23, 2024
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-trunov anton-trunov merged commit 9915bd1 into tact-lang:main May 24, 2024
3 checks passed
@Gusarich Gusarich mentioned this pull request Jun 16, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@novusnota novusnota novusnota left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

Attempts at shadowing functions from src/abi/*.ts don't produce errors
3 participants
@Gusarich @anton-trunov @novusnota