Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typechecking rules for augmented assignments #356

Merged
merged 4 commits into from
May 24, 2024
Merged

Typechecking rules for augmented assignments #356

merged 4 commits into from
May 24, 2024

Conversation

Gusarich
Copy link
Member

Closes #353

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@Gusarich Gusarich added this to the v1.3.1 milestone May 24, 2024
@Gusarich Gusarich mentioned this pull request May 24, 2024
Merged
4 tasks
anton-trunov
anton-trunov previously approved these changes May 24, 2024
View reviewed changes
@anton-trunov anton-trunov merged commit 3816c7e into tact-lang:main May 24, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@byakuren-hijiri byakuren-hijiri Awaiting requested review from byakuren-hijiri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

Missing typechecking rules for augmented assignments
2 participants
@Gusarich @anton-trunov