Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update gh actions to node 20 #360

Merged
merged 4 commits into from
May 27, 2024
Merged

chore: update gh actions to node 20 #360

merged 4 commits into from
May 27, 2024

Conversation

vitorpy
Copy link
Contributor

@vitorpy vitorpy commented May 24, 2024 •
edited
Loading

Closes #320

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@novusnota
Copy link
Member

We could also add the "packageManager": "yarn@1.22.22" field to package.json now: #320 (comment)

@anton-trunov
Copy link
Member

@vitorpy do you think this PR is ready?

@vitorpy
Copy link
Contributor Author

vitorpy commented May 26, 2024

@vitorpy do you think this PR is ready?

CHANGELOG updated, ready for review.

@vitorpy vitorpy marked this pull request as ready for review May 26, 2024 08:20
@anton-trunov anton-trunov self-assigned this May 27, 2024
@anton-trunov anton-trunov added this to the v1.3.1 milestone May 27, 2024
anton-trunov
anton-trunov approved these changes May 27, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@anton-trunov anton-trunov merged commit cc4f8e1 into tact-lang:main May 27, 2024
3 checks passed
@vitorpy vitorpy deleted the update-gh-actions-node-20 branch May 30, 2024 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.3.1
Development

Successfully merging this pull request may close these issues.

Upgrade Node.js actions
3 participants
@vitorpy @novusnota @anton-trunov