Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: optional trailing semicolons for struct/message field declarations #395

Merged
merged 2 commits into from
Jun 11, 2024
Merged

feat: optional trailing semicolons for struct/message field declarations #395

merged 2 commits into from
Jun 11, 2024

Conversation

anton-trunov
Copy link
Member

@anton-trunov anton-trunov commented Jun 10, 2024 •
edited
Loading

Closes #393

  • I have updated CHANGELOG.md
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I did not do unrelated and/or undiscussed refactorings

@anton-trunov anton-trunov added this to the v1.4.0 milestone Jun 10, 2024
@anton-trunov anton-trunov self-assigned this Jun 10, 2024
novusnota
novusnota reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@novusnota novusnota left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the motivation behind the separate StructFields and not an inline ListOf<StructField, ";"> ";"? Other parts of the grammar prefer the latter :)

@Gusarich
Copy link
Member

Agree with @novusnota

@anton-trunov
Copy link
Member Author

What's the motivation behind the separate StructFields and not an inline ListOf<StructField, ";"> ";"?

To reduce duplication

@anton-trunov
Copy link
Member Author

We can actually do the same for the other parts too. But in separate PRs

@anton-trunov anton-trunov mentioned this pull request Jun 11, 2024
Closed
@anton-trunov
Copy link
Member Author

I'm going to merge this and postpone some grammar refactoring to a later PR, this is tracked in #397

@anton-trunov anton-trunov merged commit f51821d into main Jun 11, 2024
3 checks passed
@anton-trunov anton-trunov deleted the optional-semicolon-in-struct-def branch June 11, 2024 04:13
@novusnota novusnota mentioned this pull request Jun 18, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@novusnota novusnota novusnota left review comments

@Gusarich Gusarich Awaiting requested review from Gusarich

@byakuren-hijiri byakuren-hijiri Awaiting requested review from byakuren-hijiri

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

Make semicolon (;) optional for the last struct field declaration
3 participants
@anton-trunov @Gusarich @novusnota