Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: uint1-256 and int1-257 serialization formats for Ints #558

Merged
merged 10 commits into from
Aug 25, 2024
Merged

feat: uint1-256 and int1-257 serialization formats for Ints #558

merged 10 commits into from
Aug 25, 2024

Conversation

novusnota
Copy link
Member

@novusnota novusnota commented Jul 11, 2024 •
edited
Loading

Closes #1131

Done according to built-in types of TL-B & TON:
https://docs.ton.org/develop/data-formats/tl-b-language#built-in-types.

  • I have updated CHANGELOG.md
  • I have described my contribution in Tact Docs: Describe uint1-256 and int1-257 serialization formats for Ints #896
  • I have added tests to demonstrate the contribution is correctly implemented: this usually includes both positive and negative tests, showing the happy path(s) and featuring intentionally broken cases
  • I have run all the tests locally and no test failure was reported
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota added this to the v1.5.0 milestone Jul 11, 2024
@anton-trunov anton-trunov requested a review from Gusarich July 11, 2024 17:47
@anton-trunov
Copy link
Member

anton-trunov commented Jul 26, 2024 •
edited
Loading

1.4.1 is released, we can finish this PR now

@anton-trunov anton-trunov self-assigned this Jul 27, 2024
@novusnota novusnota mentioned this pull request Jul 28, 2024
Closed
@novusnota novusnota marked this pull request as ready for review July 28, 2024 01:37
@anton-trunov
Copy link
Member

Let's bring it up-to-date and merge it

@anton-trunov anton-trunov merged commit 59677d8 into tact-lang:main Aug 25, 2024
3 checks passed
@novusnota novusnota deleted the issues/374 branch August 25, 2024 08:41
@anton-trunov anton-trunov added the misc: TL-B https://docs.ton.org/develop/data-formats/tl-b-types label Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@Gusarich Gusarich Awaiting requested review from Gusarich

Assignees

@anton-trunov anton-trunov

Labels
misc: TL-B https://docs.ton.org/develop/data-formats/tl-b-types
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

"Mutable functions" -> "Mutating functions"
2 participants
@novusnota @anton-trunov