Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): comptime functions slice, rawSlice, ascii and crc32 #951

Merged
merged 13 commits into from
Oct 28, 2024
Merged

feat(docs): comptime functions slice, rawSlice, ascii and crc32 #951

merged 13 commits into from
Oct 28, 2024

Conversation

novusnota
Copy link
Member

Issue

Closes #899.

Checklist

  • I have updated CHANGELOG.md
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

@novusnota novusnota requested a review from a team as a code owner October 13, 2024 13:08
@novusnota novusnota added this to the v1.6.0 milestone Oct 13, 2024
@anton-trunov anton-trunov requested a review from Gusarich October 13, 2024 13:58
@novusnota
Copy link
Member Author

@Gusarich please, take a look!

Gusarich
Gusarich previously approved these changes Oct 25, 2024
View reviewed changes
@Gusarich
Copy link
Member

Sorry for the delay!

@anton-trunov anton-trunov self-assigned this Oct 25, 2024
@anton-trunov
Copy link
Member

@jeshecdom does everything seem clear to you?

@anton-trunov
Copy link
Member

@novusnota there is a merge conflict in this pr

anton-trunov
anton-trunov previously approved these changes Oct 28, 2024
View reviewed changes
@novusnota
Copy link
Member Author

novusnota commented Oct 28, 2024 •
edited
Loading

I see the failure with pnpm change — either we pin the specific (prev.) pnpm version or add another command to its CI.

UPD: Apparently, pnpm were doing that for a while. Adding pnpm setup prior to any actions with it might help.

@anton-trunov
Copy link
Member

or add another command to its CI

could you please expand on this option?

@novusnota
chore(CI): try using pnpm setup as advised
1337a5d 
that may or may not require sourcing proper files on the system, like
.profile/.bashrc for systems using Bash (Linux in GitHub Actions),
.zprofile/.zshrc for systems using Zsh (macOS in GitHub Actions), etc.
@novusnota
Copy link
Member Author

novusnota commented Oct 28, 2024 •
edited
Loading

pnpm is aware of its issues since Jul 2022

UPD: Wait, Tact's CI was completely skipped this time, investigating
UPD2: Ok, this is annoying, but I'll find a simple solution. Just pinning the version of pnpm may be enough.

@novusnota
Copy link
Member Author

novusnota commented Oct 28, 2024 •
edited
Loading

The last commit worked out in terms of pnpm. But, for some reason, after sourcing .bashrc on macOS, the Node.js version downgraded to 20 from 22, and the compilation failed due to .isSubsetOf not being present on Set object (known thing)

UPD: Found it! Default Node installed on macos-latest runner (macOS 14 Arm64 at the moment) is 20. This seems like a bug of macos-runner, but that means sourcing .bashrc as advised by pnpm is actually wrong in this case.

@novusnota
chore(CI): split sorcery for Linux and macOS
f7c1383 
Because of some bug in macos-latest, which overrides the used version of
Node.js (from 22 specified to 20 installed), which then causes
compilation errors with Tact (`.isSubsetOf()` stuff)
@novusnota
typo
f91d957
@novusnota
Copy link
Member Author

novusnota commented Oct 28, 2024 •
edited
Loading

We stand victorious :)

@anton-trunov anton-trunov merged commit 757e62b into main Oct 28, 2024
18 checks passed
@anton-trunov anton-trunov deleted the closes-899 branch October 28, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anton-trunov anton-trunov anton-trunov approved these changes

@Gusarich Gusarich Gusarich left review comments

@jeshecdom jeshecdom Awaiting requested review from jeshecdom

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Document new comptime functions: slice, rawSlice, ascii and crc32
3 participants
@novusnota @Gusarich @anton-trunov