Expose Java 22 features to PL/Java user code #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The doc comment did not precisely describe the method's behavior when an unexpected exception is passed to the onUnexpected handler.
Have allowDTD(boolean) try this new-with-Java-22 property ahead of the older known properties used for the purpose. The IGNORE mode is new and will need a new method (which, of course, will only work on Java >= 22).
A new method ignoreDTD is added, which will only work on Java 22 or later. Regarding the added test, a truly minimal DTD, <!DOCTYPE a>, cannot be ignored by Java 22's SAX/DOM parser (though it can be, when using the StAX API). NullPointerException calling getActiveGrammar().isImmutable() is the result. Reported on bugreport.java.com but still awaiting assignment of a bug ID. The test added here uses an almost-minimal DTD <!DOCTYPE a []> in which the empty internal subset is enough to avoid the issue. (Including any externalID, even a dummy one, also works. Only a completely minimal DTD fails.)
This property, new in Java 22, can simply be documented; the existing setFirstSupportedProperty API method suffices to configure it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide access for client code to features introduced in Java 22.
The Java 2 release notes include new XML features that should be exposed by PL/Java's
Adjusting.XMLAPI so they can be used by client code.One new feature is already sufficiently exposed by the
setFirstSupportedPropertymethod, so only a documentation note is added.