Improve build output when no known platform rules matched #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses issue #485: anyone unlucky enough to build in an environment matching none of the probe methods for known platform rules would be faced with a JavaScript null-pointer exception instead of a message giving any clue where to look for the problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #485: anyone unlucky enough to build in an environment matching none of the probe methods for known platform rules would be faced with a JavaScript null-pointer exception instead of a message giving any clue where to look for the problem.
Adds a message explaining that no known platform rules matched, where to look in
pljava-so/pom.xmlto see why an already-supported platform might not have matched, or to add support for a new platform.