Add output to simplify troubleshooting native build #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the Windows cases, log the arguments before applying the forWindowsCRuntime() transformation (but indicating, in the message, that it will be applied). Eliminate the debug logging of the script text in ScriptingMojo and ReportScriptingMojo; Maven itself, when producing debug output, will have dumped that to the log perhaps twice already (when reading the configuration, and when configuring the mojo).
As dubious as combining any refactoring with a Javadoc/whitespace cleanup may be, it was preferable to writing new Javadoc to try to explain why it was factored as it was (with some script engine bindings being added in PGXSUtils.getScriptEngine and others in ScriptingMojo.execute, especially as that didn't match where the underlying methods lived). Adjusts javadoc options to include package-access types and members in pljava-pgxs, as some of those are exported to the script engine and ought to be documented.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add to the build scripting for
pljava-soso that the detailedPG_VERSION_STRwill appear in the Maven output to clarify what PG version has been found to build against.This should simplify responding to issues like #487, where the first obvious question is "what version of PostgreSQL is this being built against, anyway?".
The version is logged at Maven's
INFOlevel, so should be present in the output with no special effort.Also log, at Maven's
DEBUGlevel, the actual arguments being supplied to the compiler and linker. These will only be seen if Maven is run with-X, which therefore can be useful if some more thorny build issue needs to be investigated.Improve javadoc in
pljava-pgxs, to serve as a better reference for what the functions and objects used in thepljava-soPOM build script are for.