feat: stricter typescript rules

package.json

@@ -16,6 +16,9 @@
     "files": [
         "dist/"
     ],
+    "engines": {
+        "node": ">=14.0.0"
+    },
     "scripts": {
         "build": "rm -rf ./dist && tsc",
         "build:watch": "npm run build -- --watch",
@@ -67,20 +70,18 @@
         "@semantic-release/github": "^8.0.6",
         "@semantic-release/npm": "^9.0.2",
         "@semantic-release/release-notes-generator": "^10.0.3",
-        "@tada5hi/eslint-config-typescript": "^1.1.1",
-        "@types/glob": "^8.0.1",
+        "@tada5hi/eslint-config-typescript": "^1.1.2",
+        "@tada5hi/tsconfig": "^0.4.0",
         "@types/jest": "^27.5.0",
         "@types/node": "^18.11.18",
         "@types/yargs": "^17.0.22",
         "better-sqlite3": "^8.0.1",
-        "coveralls": "^3.1.0",
         "cross-env": "^7.0.3",
-        "eslint": "^8.33.0",
+        "eslint": "^8.34.0",
         "husky": "^8.0.3",
         "jest": "^27.5.1",
         "semantic-release": "^19.0.5",
         "ts-jest": "^27.1.4",
-        "ts-node": "^10.9.1",
         "typeorm": "^0.3.11",
         "typescript": "^4.9.5",
         "vitepress": "^1.0.0-alpha.46",

src/data-source/options/singleton.ts

@@ -8,14 +8,11 @@ export function setDataSourceOptions(
     options: DataSourceOptions,
     alias?: string,
 ) {
-    alias = alias || 'default';
-    instances[alias] = options;
+    instances[alias || 'default'] = options;
 }
 
 export function hasDataSourceOptions(alias?: string) : boolean {
-    alias = alias || 'default';
-
-    return Object.prototype.hasOwnProperty.call(instances, alias);
+    return Object.prototype.hasOwnProperty.call(instances, alias || 'default');
 }
 
 export async function useDataSourceOptions(alias?: string) : Promise<DataSourceOptions> {
@@ -29,7 +26,9 @@ export async function useDataSourceOptions(alias?: string) : Promise<DataSourceO
     if (!Object.prototype.hasOwnProperty.call(instancePromises, alias)) {
         instancePromises[alias] = buildDataSourceOptions()
             .catch((e) => {
-                delete instancePromises[alias];
+                if (alias) {
+                    delete instancePromises[alias];
+                }
 
                 throw e;
             });

src/data-source/singleton.ts

@@ -48,7 +48,9 @@ export async function useDataSource(alias?: string) : Promise<DataSource> {
             if (!Object.prototype.hasOwnProperty.call(initializePromises, alias)) {
                 initializePromises[alias] = instances[alias].initialize()
                     .catch((e) => {
-                        delete initializePromises[alias];
+                        if (alias) {
+                            delete initializePromises[alias];
+                        }
 
                         throw e;
                     });
@@ -64,7 +66,9 @@ export async function useDataSource(alias?: string) : Promise<DataSource> {
     if (!Object.prototype.hasOwnProperty.call(optionsPromises, alias)) {
         optionsPromises[alias] = useDataSourceOptions(alias)
             .catch((e) => {
-                delete optionsPromises[alias];
+                if (alias) {
+                    delete optionsPromises[alias];
+                }
 
                 throw e;
             });
@@ -78,7 +82,9 @@ export async function useDataSource(alias?: string) : Promise<DataSource> {
     if (!Object.prototype.hasOwnProperty.call(initializePromises, alias)) {
         initializePromises[alias] = dataSource.initialize()
             .catch((e) => {
-                delete initializePromises[alias];
+                if (alias) {
+                    delete initializePromises[alias];
+                }
 
                 throw e;
             });

src/database/create.ts

@@ -1,3 +1,4 @@
+import { DriverError, OptionsError } from '../errors';
 import {
     DatabaseCreateContext,
 } from './type';
@@ -9,21 +10,25 @@ import {
     createPostgresDatabase,
     createSQLiteDatabase,
 } from './driver';
-import { NotSupportedDriver } from './error';
 import { buildDatabaseCreateContext } from './utils';
 
 /**
  * Create database for specified driver in ConnectionOptions.
  *
- * @throws NotSupportedDriver
+ * @throws DriverError
+ * @throws OptionsError
  *
  * @param context
  */
 export async function createDatabase(context?: DatabaseCreateContext) {
     context = await buildDatabaseCreateContext(context);
 
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
+
     if (!context.options.type) {
-        throw new NotSupportedDriver(context.options.type);
+        throw DriverError.undeterminable();
     }
 
     switch (context.options.type) {
@@ -43,5 +48,5 @@ export async function createDatabase(context?: DatabaseCreateContext) {
             return createMsSQLDatabase(context);
     }
 
-    throw new NotSupportedDriver(context.options.type);
+    throw DriverError.notSupported(context.options.type);
 }

src/database/driver/cockroachdb.ts

@@ -1,4 +1,5 @@
 import { CockroachDriver } from 'typeorm/driver/cockroachdb/CockroachDriver';
+import { OptionsError } from '../../errors';
 import { DatabaseCreateContext, DatabaseDropContext } from '../type';
 import { createSimplePostgresConnection } from './postgres';
 import { buildDriverOptions, createDriver } from './utils';
@@ -24,6 +25,9 @@ export async function createCockroachDBDatabase(
     context?: DatabaseCreateContext,
 ) {
     context = await buildDatabaseCreateContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as CockroachDriver;
@@ -51,6 +55,9 @@ export async function dropCockroachDBDatabase(
     context?: DatabaseDropContext,
 ) {
     context = await buildDatabaseDropContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as CockroachDriver;

src/database/driver/mssql.ts

@@ -1,4 +1,5 @@
 import { SqlServerDriver } from 'typeorm/driver/sqlserver/SqlServerDriver';
+import { OptionsError } from '../../errors';
 import { DatabaseCreateContext, DatabaseDropContext } from '../type';
 import { DriverOptions } from './type';
 import { buildDriverOptions, createDriver } from './utils';
@@ -26,6 +27,9 @@ export async function createMsSQLDatabase(
     context?: DatabaseCreateContext,
 ) {
     context = await buildDatabaseCreateContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as SqlServerDriver;
@@ -55,6 +59,9 @@ export async function dropMsSQLDatabase(
     context?: DatabaseDropContext,
 ) {
     context = await buildDatabaseDropContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as SqlServerDriver;

src/database/driver/mysql.ts

@@ -1,4 +1,5 @@
 import { MysqlDriver } from 'typeorm/driver/mysql/MysqlDriver';
+import { OptionsError } from '../../errors';
 import { DatabaseCreateContext, DatabaseDropContext } from '../type';
 import { DriverOptions } from './type';
 import { buildDriverOptions, createDriver } from './utils';
@@ -43,6 +44,9 @@ export async function createMySQLDatabase(
     context?: DatabaseCreateContext,
 ) {
     context = await buildDatabaseCreateContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as MysqlDriver;
@@ -85,6 +89,9 @@ export async function dropMySQLDatabase(
     context?: DatabaseDropContext,
 ) {
     context = await buildDatabaseDropContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as MysqlDriver;

src/database/driver/oracle.ts

@@ -1,4 +1,5 @@
 import { OracleDriver } from 'typeorm/driver/oracle/OracleDriver';
+import { OptionsError } from '../../errors';
 import { DatabaseCreateContext, DatabaseDropContext } from '../type';
 import { DriverOptions } from './type';
 import { buildDriverOptions, createDriver } from './utils';
@@ -46,6 +47,9 @@ export async function createOracleDatabase(
     context?: DatabaseCreateContext,
 ) {
     context = await buildDatabaseCreateContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as OracleDriver;
@@ -66,7 +70,7 @@ export async function createOracleDatabase(
 }
 
 export async function dropOracleDatabase(
-    context?: DatabaseDropContext,
+    _context?: DatabaseDropContext,
 ) {
     /**
      * @link https://github.com/typeorm/typeorm/blob/master/src/driver/oracle/OracleQueryRunner.ts#L295

src/database/driver/postgres.ts

@@ -1,5 +1,7 @@
+import { isObject } from 'locter';
 import { PostgresDriver } from 'typeorm/driver/postgres/PostgresDriver';
 import { CockroachDriver } from 'typeorm/driver/cockroachdb/CockroachDriver';
+import { OptionsError } from '../../errors';
 import { DatabaseBaseContext, DatabaseCreateContext, DatabaseDropContext } from '../type';
 import { hasOwnProperty } from '../../utils';
 import { DriverOptions } from './type';
@@ -56,6 +58,9 @@ export async function createPostgresDatabase(
     context?: DatabaseCreateContext,
 ) {
     context = await buildDatabaseCreateContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as PostgresDriver;
@@ -67,7 +72,7 @@ export async function createPostgresDatabase(
         const existResult = await executeSimplePostgresQuery(connection, existQuery, false);
 
         if (
-            typeof existResult === 'object' &&
+            isObject(existResult) &&
             hasOwnProperty(existResult, 'rows') &&
             Array.isArray(existResult.rows) &&
             existResult.rows.length > 0
@@ -99,6 +104,9 @@ export async function dropPostgresDatabase(
     context?: DatabaseDropContext,
 ) {
     context = await buildDatabaseDropContext(context);
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
 
     const options = buildDriverOptions(context.options);
     const driver = createDriver(context.options) as PostgresDriver;

src/database/driver/sqlite.ts

@@ -1,5 +1,6 @@
 import path from 'path';
 import fs from 'fs';
+import { OptionsError } from '../../errors';
 import { DatabaseCreateContext, DatabaseDropContext } from '../type';
 import { buildDriverOptions } from './utils';
 import { buildDatabaseCreateContext, buildDatabaseDropContext, setupDatabaseSchema } from '../utils';
@@ -9,7 +10,14 @@ export async function createSQLiteDatabase(
 ) : Promise<void> {
     context = await buildDatabaseCreateContext(context);
 
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
+
     const options = buildDriverOptions(context.options);
+    if (!options.database) {
+        throw OptionsError.databaseNotDefined();
+    }
 
     const filePath : string = path.isAbsolute(options.database) ?
         options.database :
@@ -29,7 +37,14 @@ export async function dropSQLiteDatabase(
 ) {
     context = await buildDatabaseDropContext(context);
 
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
+
     const options = buildDriverOptions(context.options);
+    if (!options.database) {
+        throw OptionsError.databaseNotDefined();
+    }
 
     const filePath : string = path.isAbsolute(options.database) ?
         options.database :

src/database/drop.ts

@@ -1,3 +1,4 @@
+import { DriverError, OptionsError } from '../errors';
 import {
     DatabaseDropContext,
 } from './type';
@@ -9,21 +10,25 @@ import {
     dropPostgresDatabase,
     dropSQLiteDatabase,
 } from './driver';
-import { NotSupportedDriver } from './error';
 import { buildDatabaseDropContext } from './utils';
 
 /**
  * Drop database for specified driver in ConnectionOptions.
  *
- * @throws NotSupportedDriver
+ * @throws DriverError
+ * @throws OptionsError
  *
  * @param context
  */
 export async function dropDatabase(context?: DatabaseDropContext) {
     context = await buildDatabaseDropContext(context);
 
+    if (!context.options) {
+        throw OptionsError.undeterminable();
+    }
+
     if (!context.options.type) {
-        throw new NotSupportedDriver(context.options.type);
+        throw DriverError.undeterminable();
     }
 
     switch (context.options.type) {
@@ -43,5 +48,5 @@ export async function dropDatabase(context?: DatabaseDropContext) {
             return dropMsSQLDatabase(context);
     }
 
-    throw new NotSupportedDriver(context.options.type);
+    throw DriverError.notSupported(context.options.type);
 }

src/database/index.ts

@@ -1,4 +1,3 @@
-export * from './error';
 export * from './check';
 export * from './create';
 export * from './driver';

src/database/utils/context.ts

@@ -19,10 +19,7 @@ async function setDatabaseContextOptions<T extends DatabaseBaseContext>(context:
         synchronize: false,
         migrationsRun: false,
         dropSchema: false,
-        logging: [
-            ...(process.env.NODE_ENV !== 'test' ? ['query', 'error', 'schema'] : []),
-        ],
-    } as DataSourceOptions);
+    } satisfies Partial<DataSourceOptions>);
 
     return context;
 }

src/database/utils/query.ts

@@ -1,6 +1,7 @@
 /* istanbul ignore next */
+import { ObjectLiteral } from 'rapiq';
 import { SelectQueryBuilder } from 'typeorm';
 
-export function existsQuery<T>(builder: SelectQueryBuilder<T>, inverse = false) {
+export function existsQuery<T extends ObjectLiteral = ObjectLiteral>(builder: SelectQueryBuilder<T>, inverse = false) {
     return `${inverse ? 'not ' : ''}exists (${builder.getQuery()})`;
 }

src/errors/base.ts

@@ -0,0 +1,3 @@
+export class TypeormExtensionError extends Error {
+
+}