Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream chat tibble #24

Closed
wants to merge 3 commits into from
Closed

Stream chat tibble #24

wants to merge 3 commits into from

Conversation

JamesHWade
Copy link
Collaborator

@JamesHWade
Copy link
Collaborator Author

Implemented a ... input from chat() and stream(). This sticks with a chat_tibble output, which is different from #23. Not sure which you prefer @romainfrancois.

@romainfrancois
Copy link
Contributor

I think having ... in the main function is not that great after all. I'll rework #23 so that chat() takes a single argument called messages as in the API, and then we can have a set of building functions to make messages.

It's a little bit less magical ✨, but I think that's the right balance.

I also think I agree with you that the tibble output was the right call. One of the goals of #23 was to not lose the inputs, but perhaps we can organize the tibble so that it has both inputs and outputs.

msgs <- chat("you are a weather reporter. in the following messages, I'll give you a city and you give back a weather report. Ready ?")
chat(messages(msgs, "Montpellier, France"))
chat(messages(msgs, "San Francisco"))

It's important here that we retain the original prompt.

I'll play some more on #23

@romainfrancois
Copy link
Contributor

I changed a few things in #26 I can take the spirit of this PR and adjust it

@JamesHWade
Copy link
Collaborator Author

Okay, I'll close this one then. Happy to see the continued progress! It's shaping up nicely.

@JamesHWade JamesHWade closed this Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants