Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curb always appends a query to request uris #137

Closed
levinalex opened this issue Nov 9, 2012 · 4 comments
Closed

curb always appends a query to request uris #137

levinalex opened this issue Nov 9, 2012 · 4 comments

Comments

@levinalex
Copy link

When I do requests with curb, the URI always contains a query:

>> http = Curl.get("http://www.google.com/")
=> #<Curl::Easy http://www.google.com/?>    # note extra question mark
>> Curl::VERSION
=> "7.24.0" 

This broke a few tests when I switched to curb

Is this expected?

@taf2
Copy link
Owner

taf2 commented Nov 9, 2012

ah you're right that's a ruby issue see curl.rb#urlalize -> recent bug sense we started shifting more of the wrapper code from C to ruby... you can work around this or wait for a fix

the work around is

Curl::Easy.http_get("http://www.google.com/")

@levinalex
Copy link
Author

I'll use the work around.

I tried to fix this myself but didn't understand where to put a test for that.

taf2 added a commit that referenced this issue Nov 9, 2012
@taf2
Copy link
Owner

taf2 commented Nov 9, 2012

fixed for you here: d61ecd0

@taf2 taf2 closed this as completed Nov 9, 2012
@levinalex
Copy link
Author

nice. thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants