Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split ruby_curl_easy_new function into separate allocate and initiali… #329

Merged
merged 1 commit into from
Jan 3, 2018

Conversation

gcz1
Copy link
Contributor

@gcz1 gcz1 commented Oct 15, 2017

Version 0.9.4 does not allow a subclass to have different number or order of arguments to the base class.

E.g.

`class Derived < Curl::Easy
def initialize(url,foo,bar)
super(url)
end
end

c = Derived.new(nil,1,2)`

gives the following error:

in `new': wrong number of arguments (given 3, expected 0..1) (ArgumentError)

This modification splits ruby_curl_easy_new() into separate allocate and initialize functions
which allows the above code to work.

note some differences are just my editor removing trailing blanks from lines.

@taf2 taf2 merged commit e25fe6d into taf2:master Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants