Remove not working and commented tests

sample_3 and sample_4 tests was commented because they are ported from xml-rs crate and uses some reader settings which quick-xml does not have. No sense to keep them. sample_5 was ignored because parsing of UTF-16 coded documents not yet implemented. When such support will be added it will have its own test, no need to keep this one.
tafia · Jun 21, 2024 · 3321944 · 3321944
1 parent e9cab59
commit 3321944
Show file tree

Hide file tree

Showing 11 changed files with 1 addition and 213 deletions.
diff --git a/tests/README.md b/tests/README.md
@@ -1,4 +1,4 @@
-# Document descrptions
+# Document descriptions
 
 document.xml
     medium length, mostly empty tags, a few short attributes per element, no escaping
@@ -25,16 +25,7 @@ sample_1_short.txt
 sample_1_full.txt
 sample_2.xml
 sample_2_short.txt
-sample_3.xml
 sample_2_full.txt
-sample_3_short.txt
-sample_3_full.txt
-sample_4.xml
-sample_4_short.txt
-sample_4_full.txt
-sample_5_short.txt
-sample_5_utf16bom.xml
-sample_5_full.txt
 sample_ns_short.txt
 sample_ns.xml
     short, lots of namespaces, no escapes

diff --git a/tests/documents/sample_3.xml b/tests/documents/sample_3.xml
diff --git a/tests/documents/sample_3_full.txt b/tests/documents/sample_3_full.txt
diff --git a/tests/documents/sample_3_short.txt b/tests/documents/sample_3_short.txt
diff --git a/tests/documents/sample_4.xml b/tests/documents/sample_4.xml
diff --git a/tests/documents/sample_4_full.txt b/tests/documents/sample_4_full.txt
diff --git a/tests/documents/sample_4_short.txt b/tests/documents/sample_4_short.txt
diff --git a/tests/documents/sample_5_full.txt b/tests/documents/sample_5_full.txt
diff --git a/tests/documents/sample_5_short.txt b/tests/documents/sample_5_short.txt
diff --git a/tests/documents/sample_5_utf16bom.xml b/tests/documents/sample_5_utf16bom.xml
diff --git a/tests/xmlrs_reader_tests.rs b/tests/xmlrs_reader_tests.rs
@@ -67,56 +67,6 @@ fn escaped_characters_html() {
     )
 }
 
-// #[test]
-// fn sample_3_short() {
-//     test(
-//         include_str!("documents/sample_3.xml"),
-//         include_str!("documents/sample_3_short.txt"),
-//         true
-//     );
-// }
-
-// #[test]
-// fn sample_3_full() {
-//     test(
-//         include_str!("documents/sample_3.xml"),
-//         include_str!("documents/sample_3_full.txt"),
-//         false
-//     );
-// }
-
-// #[test]
-// fn sample_4_short() {
-//     test(
-//         include_str!("documents/sample_4.xml"),
-//         include_str!("documents/sample_4_short.txt"),
-//         true
-//     );
-// }
-
-// #[test]
-// fn sample_4_full() {
-//     test(
-//         include_str!("documents/sample_4.xml"),
-//         include_str!("documents/sample_4_full.txt"),
-//         false
-//     );
-//
-// }
-
-#[test]
-// FIXME: Trips on the first byte-order-mark byte
-// Expected: StartDocument(1.0, utf-16)
-// Found: InvalidUtf8([255, 254]; invalid utf-8 sequence of 1 bytes from index 0)
-#[ignore]
-fn sample_5_short() {
-    test_bytes(
-        include_bytes!("documents/sample_5_utf16bom.xml"),
-        include_bytes!("documents/sample_5_short.txt"),
-        true,
-    );
-}
-
 #[test]
 fn sample_ns_short() {
     test(