Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processing instructions should have a dedicated type #650

Closed
Mingun opened this issue Sep 15, 2023 · 0 comments · Fixed by #756
Closed

Processing instructions should have a dedicated type #650

Mingun opened this issue Sep 15, 2023 · 0 comments · Fixed by #756
Labels
bug help wanted

Comments

@Mingun
Copy link
Collaborator

Mingun commented Sep 15, 2023

Currently we use BytesText for them, but this is a text that represents a text with character and entity references, but that references MUST NOT be recognized within processing instructions.
Mingun added a commit to Mingun/quick-xml that referenced this issue Nov 21, 2023
@Mingun
Parse <??> as syntactically valid processing instruction
d6648b2 
Although empty target name isnot allowed, we would check that (or change parsing)
the same way as currently we check the presence of mandatory `version` attribute
in XML declaration. This requires introducing separate type for PI content which
will be done in tafia#650

Fixed (3):
    syntax::pi::normal_empty::async_tokio
    syntax::pi::normal_empty::borrowed
    syntax::pi::normal_empty::buffered

failures (3):
    syntax::decl::normal1::async_tokio
    syntax::decl::normal1::borrowed
    syntax::decl::normal1::buffered
@Mingun Mingun mentioned this issue Nov 21, 2023
Merged
Mingun added a commit to Mingun/quick-xml that referenced this issue Nov 21, 2023
@Mingun
Parse <??> as syntactically valid processing instruction
2e50e5c 
Although empty target name isnot allowed, we would check that (or change parsing)
the same way as currently we check the presence of mandatory `version` attribute
in XML declaration. This requires introducing separate type for PI content which
will be done in tafia#650

Fixed (3):
    syntax::pi::normal_empty::async_tokio
    syntax::pi::normal_empty::borrowed
    syntax::pi::normal_empty::buffered

failures (3):
    syntax::decl::normal1::async_tokio
    syntax::decl::normal1::borrowed
    syntax::decl::normal1::buffered
@Mingun Mingun mentioned this issue Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Introduce dedicated type for processing instruction Mingun/quick-xml
1 participant
@Mingun