Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do unescaping on Cows instead of slices to fix lifetimes #330

Closed
wants to merge 2 commits into from

Conversation

stevenroose
Copy link

@stevenroose stevenroose commented Oct 25, 2021

Fixes #329 and relates to #328.

The second commit has lifetime indications that could have been inferred, but it's safer to explicitly add them so that accidentally violating them gets noticed more easily.

Also, is there a way in which I can include my example snippet from #329 as a test somehow? Where would I put that?

@dralley
Copy link
Collaborator

dralley commented Jul 16, 2022

Would Into<Cow<..>> work? I ask because requiring Cow<..> for the escape routines would be rather inconvenient

Into<Cow<..>> ought to be implemented for String, &str, and of course Cow<..>

@dralley
Copy link
Collaborator

dralley commented Jul 16, 2022

Also, apologies for the inactivity, the original maintainer has been busy for the past few months

@dralley
Copy link
Collaborator

dralley commented Jul 22, 2022

This is likely to be addressed soon

@dralley dralley closed this Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lifetime issue in new unbuffered logic
2 participants