Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Reader into SliceReader and BufferedReader #425

Closed
wants to merge 8 commits into from
Closed

Split Reader into SliceReader and BufferedReader #425

wants to merge 8 commits into from

Commits on Jul 20, 2022

  1. Move buffered and borrowing parts of reader to separate files 

    This commit only moves code without significant changes (the only changes is:
- corrected imports
- add imports to the doc comments which have become inaccessible
)
    @Mingun @999eagle
    Mingun authored and 999eagle committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    ded1b77 View commit details
    Browse the repository at this point in the history

  2. Implement reading namespaced events for borrowing reader 

    Main code moved from `read_namespaced_event_into` to `resolve_namespaced_event_inner`
    @Mingun @999eagle
    Mingun authored and 999eagle committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    7aba3dd View commit details
    Browse the repository at this point in the history

  3. Change the check! macro to more flexibly define buffers

    @999eagle
    999eagle committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    10c736e View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2022

  1. Introduce SliceReader and BufferedReader

    @Mingun @999eagle
    Mingun authored and 999eagle committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    a018ada View commit details
    Browse the repository at this point in the history

  2. Split reader into BufferedReader and SliceReader 

    This also changes the test cases in the `reader::test::check` macro to allow for reader-specific tests.
    @999eagle
    999eagle committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    9eb0d9b View commit details
    Browse the repository at this point in the history

  3. Remove buffered access for SliceReader as events always borrow from t… 

    …he input slice
    @999eagle
    999eagle committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    b6a2af1 View commit details
    Browse the repository at this point in the history

  4. Add example for buffered access when reading from a file

    @999eagle
    999eagle committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    c972101 View commit details
    Browse the repository at this point in the history

  5. Add changelog entry

    @999eagle
    999eagle committed Jul 22, 2022
    Configuration menu
    Copy the full SHA
    c3a07b6 View commit details
    Browse the repository at this point in the history