Use borrowing read_event instead of buffering read_event_into where possible
#426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n most cases Reader's example still uses `read_event_into()` to let the reader to understand how to use reader in a generic case
Mingun
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## master #426 +/- ##
==========================================
- Coverage 49.53% 49.51% -0.03%
==========================================
Files 22 22
Lines 13861 13847 -14
==========================================
- Hits 6866 6856 -10
+ Misses 6995 6991 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
dralley
approved these changes
Jul 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes almost all usages of
read_event_intoin tests byread_event. The notable exception is theReader's documentation where I've leftread_event_intoas an example.The same changes was proposed in #425, but their was mixed with another changes, that makes that another changes less visible in the
read_event_into->read_eventnoise.This PR also removes direct examples from the
lib.rs, because they just duplicate examples in theReaderandWriter. The examples in the Readme also was synchronized with thoses two.