Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out namespace aware reader to a struct that manage the internal namespaces buffer #437

Merged
merged 11 commits into from
Jul 24, 2022

Commits on Jul 20, 2022

  1. Move buffered and borrowing parts of reader to separate files

    This commit only moves code without significant changes (the only changes is:
    - corrected imports
    - add imports to the doc comments which have become inaccessible
    )
    Mingun authored and 999eagle committed Jul 20, 2022
    Configuration menu
    Copy the full SHA
    ded1b77 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2022

  1. Merge xmlrs_display into test_bytes

    The following commit will not allow to call `reader.decoder()` while
    reference to ResolveResult is valid, so we'll need to save decoder
    before the loop and update it when it could be changed
    Mingun committed Jul 23, 2022
    Configuration menu
    Copy the full SHA
    136e77d View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2022

  1. ns: Introduce an NsReader struct and move all namespace-related API…

    … to it
    
    This commit only moves code and do not introduce any improvements
    Mingun committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    f3c0c1b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    a90f83b View commit details
    Browse the repository at this point in the history
  3. ns: Group unbounded impl blocks

    This commit only moves code
    Mingun committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    6dd6b53 View commit details
    Browse the repository at this point in the history
  4. ns: Add API that allow to not resolve namespaces after each event read

    `Deserializer` implementation can buffer events and it will not be able
    to buffer the `resolve` result because it is bound to the `NsReader`
    Mingun committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    6dc166f View commit details
    Browse the repository at this point in the history
  5. ns: Implement namespace reading for borrowed reader

    Co-authored-by: Daniel Alley <dalley@redhat.com>
    Mingun and dralley committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    0759dfd View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    16168e1 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8759d3a View commit details
    Browse the repository at this point in the history
  8. ns: Remove DerefMut into Reader because we do not want that user ca…

    …ll non-namespace-aware mutation methods
    
    Because `impl DerefMut<Target=Reader> for NsReader` is removed, all Reader's
    methods that accept `&mut self` won't be available for the NsReader, including
    configuration methods.
    
    Because we need a way to configure our reader, we need to reimplement necessary
    methods that accepts `&mut self`. In order to not duplicate the code and the doc
    of this configure methods, they was put into the macro `configure_methods!` and
    embed to both readers.
    Mingun committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    f8bae05 View commit details
    Browse the repository at this point in the history
  9. ns: Add a note about rules for closing tags

    Co-authored-by: Daniel Alley <dalley@redhat.com>
    Mingun and dralley committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    45be217 View commit details
    Browse the repository at this point in the history