Implement read_text
- a method that returns a text between two tags
#455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method introduces
Reader::read_text
andNsReader::read_text
methods, that returns text between open and closed tags.At the same time it removes
Reader::read_text_into
, because:read_text
#154, the behavior of this method should be changed to match the behavior of the new method, but this is hard to implement currently, because when we read events, we store in the user-provided buffer only data, that required for event content, but omitting the part corresponding to markup. But new method requires that bytes too. Implementing this behavior requires further investigations, therefore, I have decided so far to make an implementation only for the borrowing reader.