Start rewrite serde serialization tests #468
Conversation
…ts serialization for now Serialization will reworked soon and new tests will be written
The `without_root` tests will be added soon (review with with whitespace ignored mode)
Codecov Report
@@ Coverage Diff @@
## master #468 +/- ##
==========================================
- Coverage 52.70% 51.05% -1.66%
==========================================
Files 29 30 +1
Lines 13535 13143 -392
==========================================
- Hits 7134 6710 -424
- Misses 6401 6433 +32
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I'd like to try to not be rewriting the serde code in parallel - if there are relevant pieces of #441 which you would be willing to merge separately, let's try to do that. |
|
For now I see that we are practically do not intersect -- it seems that serializer implementation does not depend much on the encoding, because it always writes UTF-8 strings. I rewriting serializer completely, so it will use |
Changelog.md
Outdated
| @@ -17,6 +17,7 @@ | |||
| ### Misc Changes | |||
|
|
|||
| - [#468]: Content of `DeError::Unsupported` changed from `&'static str` to `Cow<'static, str>` | |||
| - [#468]: Ensure, that map keys could only types that serialized as primitives only | |||
There was a problem hiding this comment.
Ensure that map keys are restricted to only types that can be serialized as primitives
…zed as primitives Co-authored-by: Daniel Alley <dalley@redhat.com>
Our serde serializer a far from ideal, but rewriting it requires a very long commit history, as I think (I already have 20 commits and I suspect that I'll double that count...). Because I'm not a big fan of long PRs, I propose that changes, that rewrites tests without changing behavior. Next tests that I plan to add will test new corrected behavior, that is why this PR could look slightly unfinished.
Added a commit that ensures, that key name is always produces valid XML name for an element