Introduce dedicated Text type for DeEvent::Text event
#572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This type would be useful when span support would be added or to implement configurable stripping leading / trailing spaces
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 64.21% 63.99% -0.22%
==========================================
Files 33 33
Lines 16583 16517 -66
==========================================
- Hits 10648 10570 -78
- Misses 5935 5947 +12
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dralley
reviewed
Mar 4, 2023
| End(BytesEnd::new("inner")), | ||
| ] | ||
| ); | ||
| assert_eq!(de.write, vec![]); | ||
| assert_eq!(de.next().unwrap(), Text(Cow::Borrowed("text"))); | ||
| assert_eq!(de.next().unwrap(), Text("text".into())); |
There was a problem hiding this comment.
I'm assuming we don't care whether it was borrowed or owned? (not that this aspect is being properly tested currently)
There was a problem hiding this comment.
Yes, we don't care. Only the fact that Text event is generated is tested here
dralley
approved these changes
Mar 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new type would be useful in corrent implementation of #561 and #552, because introduces a place for additional data (a range of text that we should get after trim (assumed that Text would contain untrimmed text) and a span of a text)