Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes ElementWriter.write_inner_content take FnOnce instead of Fn #579

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

Tpt
Copy link
Contributor

@Tpt Tpt commented Mar 17, 2023

This closure is only evaluated once

Copy link
Collaborator

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a changelog entry

@codecov-commenter
Copy link

Codecov Report

Merging #579 (1f57a02) into master (642de0a) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #579      +/-   ##
==========================================
- Coverage   64.24%   64.21%   -0.03%     
==========================================
  Files          34       34              
  Lines       16624    16623       -1     
==========================================
- Hits        10680    10675       -5     
- Misses       5944     5948       +4     
Flag Coverage Δ
unittests 64.21% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/writer.rs 88.71% <ø> (ø)

... and 5 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Tpt
Copy link
Contributor Author

Tpt commented Mar 17, 2023

Thank you!

Please add a changelog entry

Done

@dralley dralley merged commit dd4c89e into tafia:master Mar 17, 2023
Mingun added a commit to Mingun/quick-xml that referenced this pull request Mar 18, 2023
crapStone added a commit to Calciumdibromid/CaBr2 that referenced this pull request Mar 29, 2023
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [quick-xml](https://github.com/tafia/quick-xml) | dependencies | patch | `0.28.0` -> `0.28.1` |

---

### Release Notes

<details>
<summary>tafia/quick-xml</summary>

### [`v0.28.1`](https://github.com/tafia/quick-xml/blob/HEAD/Changelog.md#&#8203;0281----2023-03-19)

[Compare Source](tafia/quick-xml@v0.28.0...v0.28.1)

##### Misc Changes

-   [#&#8203;579]: `ElementWriter.write_inner_content` now uses a `FnOnce` instead of a more restrictive `Fn` closure

[#&#8203;579]: tafia/quick-xml#579

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xOS4wIiwidXBkYXRlZEluVmVyIjoiMzUuMTkuMCJ9-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Co-authored-by: crapStone <crapstone01@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1826
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants