-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework errors #675
Rework errors #675
Commits on Oct 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for e0adb66 - Browse repository at this point
Copy the full SHA e0adb66View commit details -
Strange, that cargo_fmt did reformat the code that previously was acceptable and didn't changed in the previous commit
Configuration menu - View commit details
-
Copy full SHA for da2823d - Browse repository at this point
Copy the full SHA da2823dView commit details -
Remove
DeError::UnexpectedEnd
, because this error could be returned…… only if the deserializer has a bug
Configuration menu - View commit details
-
Copy full SHA for d9520c4 - Browse repository at this point
Copy the full SHA d9520c4View commit details -
Remove
DeError::ExpectedStart
, callVisitor::visit_borrowed_str
o……r `visit_string` instead It is responsibility of a `Visitor` to return an error if the provided data can not be handled
Configuration menu - View commit details
-
Copy full SHA for 77e5a2c - Browse repository at this point
Copy the full SHA 77e5a2cView commit details -
Do not return
DeError::Unsupported
inSimpleTypeDeserializer
, cal……l `deserialize_str` instead Deserializer methods are only hints, if deserializer could not satisfy request, it should return the data that it has. It is responsibility of a Visitor to return an error if it does not understand the data UnitDeserializer::new() available only since serde 1.0.139 (serde-rs/serde#2246)
Configuration menu - View commit details
-
Copy full SHA for a5490f2 - Browse repository at this point
Copy the full SHA a5490f2View commit details -
Do not return
DeError::Unsupported
in attempt to deserialize byte dataProvide to visitor a string or a map instead. Deserializer methods are only hints, if deserializer could not satisfy request, it should return the data that it has. It is responsibility of a Visitor to return an error if it does not understand the data
Configuration menu - View commit details
-
Copy full SHA for f845369 - Browse repository at this point
Copy the full SHA f845369View commit details -
Do not return
DeError::Unsupported
in attempt to deserialize newtyp……e, tuple or struct from QName Provide to visitor a unit instead. Deserializer methods are only hints, if deserializer could not satisfy request, it should return the data that it has. It is responsibility of a Visitor to return an error if it does not understand the data
Configuration menu - View commit details
-
Copy full SHA for 77a2fad - Browse repository at this point
Copy the full SHA 77a2fadView commit details -
Replace
Error::UnexpectedEof
andError::UnexpectedBang
by `Error:……:Syntax(SyntaxError)`
Configuration menu - View commit details
-
Copy full SHA for 29ca886 - Browse repository at this point
Copy the full SHA 29ca886View commit details
Commits on Nov 3, 2023
-
Replace
Error::UnexpectedEof
byError::IllFormed(MissedEnd)
in re……sults of `read_to_end` Co-authored-by: Daniel Alley <dalley@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for 0e5188d - Browse repository at this point
Copy the full SHA 0e5188dView commit details -
Do not convert
DeError::InvalidXml(Error::IllFormed(MissedEnd))
to ……`DeError::UnexpectedEof`
Configuration menu - View commit details
-
Copy full SHA for f7ee91f - Browse repository at this point
Copy the full SHA f7ee91fView commit details -
Replace
DeError::UnexpectedEof
byError::IllFormed(MissedEnd)
whe……n read text in a tag and cover that case by test
Configuration menu - View commit details
-
Copy full SHA for a91843e - Browse repository at this point
Copy the full SHA a91843eView commit details -
Replace
DeError::UnexpectedEof
byError::IllFormed(MissedEnd)
in ……cases where Eof was received while waiting end tag
Configuration menu - View commit details
-
Copy full SHA for 7d20324 - Browse repository at this point
Copy the full SHA 7d20324View commit details -
Replace
DeError::UnexpectedEof
byError::IllFormed(MissedEnd)
and…… cover case for a field of a sequential type
Configuration menu - View commit details
-
Copy full SHA for 4972d4f - Browse repository at this point
Copy the full SHA 4972d4fView commit details -
DeEvent::Eof
is impossible inMapValueDeserializer::variant_seed
,…… explicitly show this using `unreachable!` when we in that branch, `Start` or `Text` event already was picked
Configuration menu - View commit details
-
Copy full SHA for cee2725 - Browse repository at this point
Copy the full SHA cee2725View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5489df - Browse repository at this point
Copy the full SHA d5489dfView commit details -
Report trimmed found name in EndEventMismatch error when end tag has …
…no corresponding open tag
Configuration menu - View commit details
-
Copy full SHA for 00de446 - Browse repository at this point
Copy the full SHA 00de446View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff28390 - Browse repository at this point
Copy the full SHA ff28390View commit details -
Inline mismatch_err closure because in the next commit it will genera…
…te 2 different errors
Configuration menu - View commit details
-
Copy full SHA for 73fcf23 - Browse repository at this point
Copy the full SHA 73fcf23View commit details -
Replace
Error::EndEventMismatch
byError::IllFormed(UnmatchedEnd)
…… in cases where start tag is missing
Configuration menu - View commit details
-
Copy full SHA for 6670800 - Browse repository at this point
Copy the full SHA 6670800View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4d887a2 - Browse repository at this point
Copy the full SHA 4d887a2View commit details -
IllFormed(UnmatchedEnd)
should be reported always because lone clos……ed tags are not allowed even in HTML
Configuration menu - View commit details
-
Copy full SHA for a4febad - Browse repository at this point
Copy the full SHA a4febadView commit details -
Configuration menu - View commit details
-
Copy full SHA for 596edd6 - Browse repository at this point
Copy the full SHA 596edd6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 53c6b4e - Browse repository at this point
Copy the full SHA 53c6b4eView commit details -
Better document
Error::XmlDeclWithoutVersion
andError::EmptyDocType
Co-authored-by: Daniel Alley <dalley@redhat.com>
Configuration menu - View commit details
-
Copy full SHA for a049cd2 - Browse repository at this point
Copy the full SHA a049cd2View commit details