Fix processing instruction parsing #753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, `>`, `'` and `"`
failures (3):
reader::async_tokio::test::read_event_into_async::processing_instruction
reader::buffered_reader::test::read_event_impl::processing_instruction
reader::slice_reader::test::read_event_impl::processing_instruction
Fixes (3):
reader::async_tokio::test::read_event_into_async::processing_instruction
reader::buffered_reader::test::read_event_impl::processing_instruction
reader::slice_reader::test::read_event_impl::processing_instruction
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #753 +/- ##
==========================================
+ Coverage 61.24% 61.82% +0.57%
==========================================
Files 39 40 +1
Lines 16277 16728 +451
==========================================
+ Hits 9969 10342 +373
- Misses 6308 6386 +78
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dralley
approved these changes
Jun 5, 2024
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the situation with parsing
<?pi >?>. Previously we erroneously consume only<?pi >and return error about not closed processing instruction.