Make const as many functions as possible
#759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #759 +/- ##
==========================================
+ Coverage 61.81% 61.88% +0.06%
==========================================
Files 41 41
Lines 16798 16838 +40
==========================================
+ Hits 10384 10420 +36
- Misses 6414 6418 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dralley
approved these changes
Jun 16, 2024
is_whitespace is trivial therefore not tested Also make `name_len` function `const`
- Attr::key() - Attr::value() - Attributes::html() - Attributes::new() - BytesDecl::from_start() - Decoder::encoding() - Deserializer::get_ref() - IoReader::get_ref() - LocalName::into_inner() - Namespace::into_inner() - NsReader::config() - NsReader::prefixes() - Prefix::into_inner() - QName::into_inner() - Reader::buffer_position() - Reader::config() - Reader::decoder() - Reader::error_position() - Reader::get_ref() - resolve_html5_entity() - resolve_predefined_entity() - resolve_xml_entity() - SliceReader::get_ref() - Writer::get_ref() - Writer::new()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think, that all those functions are such basic, that unlikely will be changed in that way that would prevent them from being
const. So I added this keyword.This is all that can be
constat the moment, I checked all the other functions.