Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add allow_unmatched_ends reader config option #772

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

torokati44
Copy link
Contributor

Fixes #770.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.29%. Comparing base (7558577) to head (e9b7716).
Report is 51 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #772      +/-   ##
==========================================
- Coverage   61.81%   60.29%   -1.53%     
==========================================
  Files          41       41              
  Lines       16798    16229     -569     
==========================================
- Hits        10384     9785     -599     
- Misses       6414     6444      +30     
Flag Coverage Δ
unittests 60.29% <100.00%> (-1.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Mingun Mingun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a changelog entry, like I did that in #771:

  • In New Features section add - [#772]: <short description>
  • In the end of Unreleased section add [#772]: https://github.com/tafia/quick-xml/pull/772 (that is place for all links for a release)
  • Keep two blank lines between link from the previous point and section of the last released version, so each releases separated by two blank lines

@torokati44
Copy link
Contributor Author

Yep, there you go, I hope I did it right.

@Mingun Mingun merged commit ff65ca1 into tafia:master Jun 26, 2024
@torokati44
Copy link
Contributor Author

Can we expect a v0.35.0 on crates.io sometime soon?

@Mingun
Copy link
Collaborator

Mingun commented Jun 27, 2024

Yes, I think I release new version in the end of week. I have two ready-to-merge PRs with bug fixes which I want to include in this release because they likely will be accepted in this time.

@torokati44
Copy link
Contributor Author

Great, thanks!

@Mingun
Copy link
Collaborator

Mingun commented Jun 29, 2024

I just released 0.35.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabling check_end_names is not effective since v0.32
3 participants