Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.2 #19

Merged
merged 10 commits into from
Jun 4, 2024
Merged

1.2.2 #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
f0ae59f
Merge pull request #8 from tagconcierge/feature/body-event-on-library…
mfrankiewicz May 14, 2024
9f40b26
Merge pull request #9 from tagconcierge/feature/body-event-on-library…
mfrankiewicz May 14, 2024
401018f
Merge pull request #10 from tagconcierge/feature/body-event-on-librar…
mfrankiewicz May 14, 2024
8f641a1
Merge pull request #11 from tagconcierge/feature/body-event-on-librar…
mfrankiewicz May 14, 2024
a000d76
Merge pull request #12 from tagconcierge/feature/body-event-on-librar…
mfrankiewicz May 14, 2024
6b0e54c
Merge pull request #13 from tagconcierge/feature/body-event-on-librar…
mfrankiewicz May 14, 2024
e7741c9
Merge pull request #15 from tagconcierge/bugfix/trigger-ready-event-o…
mfrankiewicz May 14, 2024
2a4fbc5
Merge pull request #17 from tagconcierge/main
mfrankiewicz May 14, 2024
d575667
fixes bar mode display mode responsiveness and missing wall after set…
mfrankiewicz Jun 4, 2024
09ec482
Merge pull request #18 from tagconcierge/release/1.2.2
mfrankiewicz Jun 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,14 +75,16 @@ function saveConsentState(consentState) {
}

// Components
function createMain(gtmCookiesConfig) {
function createMain(config) {
var main = document.createElement("div");
main.setAttribute('id', 'consent-banner-main');
main.setAttribute('data-mode', config.display.mode);
main.setAttribute('data-wall', config.display.wall ?? false);
main.style.display = 'none';
return main;
}

function createWall(gtmCookiesConfig) {
function createWall(config) {
var wall = document.createElement("div");
wall.setAttribute('id', 'consent-banner-wall');
return wall;
Expand Down Expand Up @@ -227,7 +229,9 @@ function showSettings(main) {
function hideSettings(main) {
main.style.display = 'block';
main.querySelector('#consent-banner-settings').style.display = 'none';
hideWall(main)
if ('true' !== main.getAttribute('data-wall')) {
hideWall(main);
}
}


Expand Down
2 changes: 1 addition & 1 deletion styles/light.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
#consent-banner-settings > div > form div:nth-child(2) {
max-height: none;
}
#consent-banner-modal {
#consent-banner-main:not([data-mode="bar"]) #consent-banner-modal {
width: auto;
left: 5% !important;
right: 5% !important;
Expand Down
1 change: 1 addition & 0 deletions www/bar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<!doctype html>
<html lang="en">
<head>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<style type="text/css">
body {
font-family: system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", "Noto Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
Expand Down
1 change: 1 addition & 0 deletions www/modal.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
<!doctype html>
<html lang="en">
<head>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<style type="text/css">
body {
font-family: system-ui, -apple-system, "Segoe UI", Roboto, "Helvetica Neue", "Noto Sans", "Liberation Sans", Arial, sans-serif, "Apple Color Emoji", "Segoe UI Emoji", "Segoe UI Symbol", "Noto Color Emoji";
Expand Down