Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new streetcomplete taginfo source #134

Merged
merged 1 commit into from
Jul 28, 2022
Merged

Conversation

matkoniecz
Copy link
Contributor

@matkoniecz matkoniecz commented Jul 27, 2022

It is not yet reviewed by other (neither code nor data) but it is substantially superior to the current resource

Maybe in future it will be merged into StreetComplete itself and link will change, but it can take some time (especially as generator is a gigantic pile of hacks and hardcoded answers and magic and is parsing StreetComplete itself)

Generator is at https://github.com/matkoniecz/Zazolc/blob/taginfo/buildSrc/src/main/java/UpdateTaginfoListingTask.kt if anyone is curious - code review is welcome (I will submit it as a PR to StreetComplete repo, but first I will review it with help of someone else unfamiliar with SC)

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Jul 28, 2022

Is x-content-type-options | nosniff (it seems to block JS and CSS, and should be not impacting JSON if I am right) or other special header a problem? See say https://github.blog/2013-04-24-heads-up-nosniff-header-support-coming-to-chrome-and-firefox/

Such file seems to be cached by taginfo, not it loaded by any person viewing project info - so hotlinking ban should not be a problem here.

BTW, would it be fine to use https://raw.githubusercontent.com/streetcomplete/StreetComplete/master/res/graphics/quest/bicycle_parking.svg and similar as an icon for some entries? Or is nosniff also a problem for taginfo? I see that icons are also cached, so hotlinking ban should not be a problem here.

@joto
Copy link
Member

joto commented Jul 28, 2022

Sorry, I don't understand what you are trying to do here. Is this new URL the new official one for StreetComplete? You are talking about this not beeing merged, so is this coordinated with the StreetComplete maintainer? If this is not finished yet, but you want to get it into Taginfo to test it, I suggest you submit this under a different name (streetcomplete_dev or so) until this is official.

Regarding nosniff and all that: All ressources should be available in a form that a browser can show them. I don't know what the nosniff does, a CORS header has always been enough for me, but I don't know all the details of modern browsers.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Jul 28, 2022

Is this new URL the new official one for StreetComplete?

no, but old one is not official, not maintained, outdated and has errors - for example listing of language tags is wrong (for example, as far as I see name:pl is never used in bus stop name quest answers, in Poland only name tag is used)

this one is also not official (though I am a significant contributor to SC), it is maintained, is not outdated and has no obvious errors which I can spot (as ones that I could spot were fixed)

it also reports many tags which were not reported on the old one despite having much stricter criteria

if this is not finished yet, but you want to get it into Taginfo to test it, I suggest you submit this under a different name (streetcomplete_dev or so) until this is official.

I can do this, but old one is not official and listing quality is substantially worse there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants