Make pyflakes happy, comment out unused python unit test variable dec… #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exarkun
reviewed
Feb 28, 2017
|
|
||
| def measure_sleep(x, clock): | ||
| st = clock() | ||
| #st = clock() | ||
| time.sleep(x) | ||
|
|
There was a problem hiding this comment.
How about just deleting calib_clock instead? It has no callers as far as I can tell. What good is it?
| sig_R,sig_S = sig[:32],sig[32:] | ||
| newsig_R,newsig_S = newsig[:32],newsig[32:] | ||
| #sig_R,sig_S = sig[:32],sig[32:] | ||
| #newsig_R,newsig_S = newsig[:32],newsig[32:] | ||
| self.failUnlessEqual(hexlify(newsig), hexlify(sig)) # deterministic sigs |
There was a problem hiding this comment.
I'd say just delete the lines, instead. Alternatively, rewrite them as English comments. "The first 32 bytes of sig are .... The rest of the bytes are ...".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…larations