[SYCL-Upstreaming] Fix a crash when an argument of skep function is not trivially-copyable #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivially-copyable device-copyable doesn't mean trivially-copyable, so we may encounter arguments that need cleanup. Adds test that verifies presence of the dtor call in the synthesized code.
Fznamznon
changed the title
tahonermann
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
Thanks, @Fznamznon. This looks good, at least for now. As part of the decomposition work we'll need to decide how to handle types that aren't implicitly device copyable and that don't have a specialization of the sycl::is_device_copyable trait. Regardless though, this looks like a good change to me.
tahonermann
changed the title
tahonermann
merged commit 87f0c2b
into
tahonermann:sycl-upstream-fe-sycl_kernel_entry_point-host
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
device-copyable doesn't mean trivially-copyable, so we may encounter arguments that need cleanup. Adds test that verifies presence of the dtor call in the synthesized code.