Remove unused assets state references

These were overlooked during the process of segregating prices from the assets slice
tahowallet · Jul 27, 2023 · 234d1c3 · 234d1c3
1 parent 8678d0e
commit 234d1c3
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 11 deletions.
diff --git a/background/redux-slices/earn-utils/getPoolAPR.ts b/background/redux-slices/earn-utils/getPoolAPR.ts
@@ -1,7 +1,6 @@
 import { BigNumber } from "ethers"
 import { AnyAsset } from "../../assets"
 import { HexString } from "../../types"
-import { AssetsState } from "../assets"
 import { getContract, getCurrentTimestamp } from "../utils/contract-utils"
 import VAULT_ABI from "../../lib/vault"
 import { DOGGO } from "../../constants"
@@ -66,7 +65,6 @@ const getPoolAPR = async ({
     decimals: number
     contractAddress: HexString
   }
-  assets: AssetsState
   prices: PricesState
   vaultAddress: HexString
 }): Promise<{

diff --git a/background/redux-slices/earn.ts b/background/redux-slices/earn.ts
@@ -18,7 +18,6 @@ import {
   getProvider,
   getSignerAddress,
 } from "./utils/contract-utils"
-import { AssetsState } from "./assets"
 import { enrichAssetAmountWithMainCurrencyValues } from "./utils/asset-utils"
 import { ETHEREUM } from "../constants"
 import { EVMNetwork } from "../networks"
@@ -415,9 +414,8 @@ export const updateVaults = createBackgroundAsyncThunk(
   "earn/updateLockedValues",
   async (vaultsToUpdate: AvailableVault[], { getState, dispatch }) => {
     const currentState = getState()
-    const { assets, prices } = currentState as {
+    const { prices } = currentState as {
       earn: EarnState
-      assets: AssetsState
       prices: PricesState
     }
     const provider = getProvider()
@@ -445,7 +443,6 @@ export const updateVaults = createBackgroundAsyncThunk(
 
       const vaultAPR = await getPoolAPR({
         asset: vault.asset,
-        assets,
         prices,
         vaultAddress: vault.vaultAddress,
       })

diff --git a/background/tests/earn/earn.test.ts b/background/tests/earn/earn.test.ts
@@ -5,7 +5,7 @@
 import { BigNumber } from "ethers"
 import * as getTokenPrice from "../../redux-slices/earn-utils/getTokenPrice"
 import { getDoggoPrice, getPoolAPR } from "../../redux-slices/earn-utils"
-import { assets, prices } from "./assets.mock"
+import { prices } from "./assets.mock"
 import * as contractUtils from "../../redux-slices/utils/contract-utils"
 
 const mainCurrencySymbol = "USD"
@@ -87,7 +87,6 @@ describe("Earn", () => {
 
       const APR = await getPoolAPR({
         asset,
-        assets,
         prices,
         vaultAddress: "0x0",
       })
@@ -114,7 +113,6 @@ describe("Earn", () => {
 
       const APR = await getPoolAPR({
         asset,
-        assets,
         prices,
         vaultAddress: "0x0",
       })
@@ -146,7 +144,6 @@ describe("Earn", () => {
 
       const APR = await getPoolAPR({
         asset,
-        assets,
         prices,
         vaultAddress: "0x0",
       })

diff --git a/ui/hooks/nft-hooks.ts b/ui/hooks/nft-hooks.ts
@@ -1,4 +1,5 @@
 import {
+  getPricesState,
   selectFilteredTotalFloorPrice,
   selectMainCurrencySymbol,
 } from "@tallyho/tally-background/redux-slices/selectors"
@@ -30,7 +31,7 @@ export const useTotalNFTsFloorPrice = (): {
 } => {
   const mainCurrencySymbol = useBackgroundSelector(selectMainCurrencySymbol)
   const totalFloorPrice = useBackgroundSelector(selectFilteredTotalFloorPrice)
-  const allPrices = useBackgroundSelector((state) => state.prices)
+  const allPrices = useBackgroundSelector(getPricesState)
 
   const ETHPricePoint = selectAssetPricePoint(
     allPrices,