Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom asset copy tweak #3325

Closed
mr-michael opened this issue Apr 27, 2023 · 7 comments · Fixed by #3478
Closed

Add custom asset copy tweak #3325

mr-michael opened this issue Apr 27, 2023 · 7 comments · Fixed by #3478
Assignees

Comments

@mr-michael
Copy link
Contributor

mr-michael commented Apr 27, 2023

Let's change to:

Asset already added.
If you're not seeing it, that means your balance is 0. Have a positive balance but still not seeing it? Make sure you've disabled the "Hide asset balances under $2" options from Settings and check the Wallet tab again.

Screen Shot 2023-04-26 at 8 52 24 PM

@mr-michael mr-michael added this to the Support bare RPC providers milestone Apr 27, 2023
@hyphenized
Copy link
Contributor

image

I feel that the previous message conveyed this information better, although the copy was still wrong for the related setting. Note that the asset might not have been added, but already exists because it's part of a token list.

image

@jagodarybacka
Copy link
Contributor

Yeah I think that message is too long, can we maybe split it into paragraphs or add a tooltip or Notion page about it?
cc @VladUXUI

@VladUXUI
Copy link
Contributor

VladUXUI commented May 9, 2023

Users are trying to add an asset that already exists, this can be for 1 of 2 reasons:
1 - They have 0 balance so they don't see it
2 - They only have dust, need to toggle off "hide assets"

I feel like the previous version had a bit better context. The "title" reinforced the state of the asset and the body text provided a fix for the edgecases.

@mr-michael can you go provide a bit more context as to why you would like to change?

@Shadowfiend
Copy link
Contributor

Shadowfiend commented May 9, 2023

Is there a reason we wouldn't make this reactive to what we know? That is, tell them that they should see it/they can't see it because we know the balance is below $2 and they need to drop it/tell them they can't see it because balance is 0?

Additionally, it feels like we should forcibly display all assets the user has added explicitly even for a zero balance if that <$2 setting is off. I'm sure that conversation already happened and I'm a little late to it but--is that happening already, did we explicitly decide not to do that, or did we avoid it for technical reasons?

@hyphenized
Copy link
Contributor

@VladUXUI Are there any UX concerns over making this reactive?

Additionally, it feels like we should forcibly display all assets the user has added explicitly even for a zero balance if that <$2 setting is off.

I think this is being handled here #3313

@VladUXUI
Copy link
Contributor

@VladUXUI Are there any UX concerns over making this reactive?

Nope, having them be more specific should be awesome

@kkosiorowska
Copy link
Contributor

kkosiorowska commented Jun 14, 2023

@VladUXUI Are there any UX concerns over making this reactive?

Nope, having them be more specific should be awesome

We can therefore try to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants