Make custom tokens visible in the asset list even if they have a balance of zero #3313

kkosiorowska · 2023-04-26T12:24:22Z

What

Currently, when a user adds a token manually, it will not show up in the list of assets when the balance is zero. We should display an asset on the list even when its balance is empty.

UI

To Test

add a custom token whose balance is zero (0x841fad6eae12c286d1fd18d1d525dffa75c7effe for Fandom network)
the asset should appear in the list of assets
hide dust in the settings, the token should be displayed on the list of hidden assets
make sure that we do not show other assets that have a balance of zero

Latest build: extension-builds-3313 (as of Wed, 14 Jun 2023 15:42:00 GMT).

* hide assets with balances under $2 * display custom assets when balance is 0

jagodarybacka

Some improvements ⬇️

Also - on other networks trusted and untrusted assets switched sections:

Screen.Recording.2023-05-03.at.11.52.19.mov

background/redux-slices/utils/asset-utils.ts

background/redux-slices/selectors/accountsSelectors.ts

background/redux-slices/accounts.ts

jagodarybacka · 2023-05-03T09:46:41Z

background/redux-slices/accounts.ts

 if (
 updatedAccountBalance.assetAmount.amount === 0n &&
- existingAccountData.balances[updatedAssetSymbol] === undefined &&
- !isBuiltInNetworkBaseAsset(asset, network) // add base asset even if balance is 0
+ existingAccountData.balances[updatedAssetSymbol] === undefined
 ) {
- return
+ // add base asset even if balance is 0 or is a custom asset
+ if (


Can we combine these two ifs?

kkosiorowska · 2023-05-08T09:50:39Z

Let's wait with this PR until we merge this one.

hyphenized · 2023-05-08T10:00:04Z

Let's wait with this PR until we merge this one.

Good catch! The conditionals for token visibility have already been refactored there but we can also cherry pick some of that work here if we need to push this out faster

0xDaedalus · 2023-05-08T14:18:47Z

Lets add a couple of unit tests here as well - we should just need two: One for computeCombinedAssetAmountsData and one for updateAccountBalance

jagodarybacka · 2023-06-06T11:12:58Z

@kkosiorowska Is this PR still valid and we should merge it at some point or not?

kkosiorowska · 2023-06-06T11:23:27Z

@kkosiorowska Is this PR still valid and we should merge it at some point or not?

@jagodarybacka PR was blocked by verified/unverified tokens. It needs to be updated and tested again. I should be looking into it this week.

VladUXUI · 2023-06-14T08:34:50Z

I don't think this is a good idea fwiw.
If i sell my asset, how do i hide the dust from it?

…ibility

kkosiorowska · 2023-06-14T11:32:34Z

I don't think this is a good idea fwiw. If i sell my asset, how do i hide the dust from it?

We are able to force a newly added asset to be displayed (when the balance is 0). In the case where we sell an asset and its balance is close to zero we are able to hide it.

Shadowfiend · 2023-06-15T01:12:03Z

I don't think this is a good idea fwiw. If i sell my asset, how do i hide the dust from it?

We are able to force a newly added asset to be displayed (when the balance is 0). In the case where we sell an asset and its balance is close to zero we are able to hide it.

I think if we've implemented, in the custom token add page, the message that the asset will be added but hidden due to having 0 balance + hide dust being enabled, then we should avoid getting to this level of contortion in the code, because it's going to have the potential to get real nasty. e.g. when do we consider an asset to be ”new“ and subject to this? Do we have to wait for balance to go over 0 and then drop back under it? Are we instead saying the asset is visible at exactly 0 but not at fractionally over 0? Etc.

EDIT to say: if it's not clear, I'm basically for killing this PR completely, BUT I think it's ultimately a call for Vlad/Haley to make 😁

hyphenized · 2023-06-16T04:42:43Z

background/redux-slices/accounts.ts

- !isBuiltInNetworkBaseAsset(asset, network) // add base asset even if balance is 0
+ // add base asset even if balance is 0 or is a custom asset
+ !(
+ isUntrustedAsset(asset) ||


If the asset already exists it will likely be part of a token list assets and not a custom asset, in that case this won't trigger right?

kkosiorowska · 2023-06-16T07:46:24Z

EDIT to say: if it's not clear, I'm basically for killing this PR completely, BUT I think it's ultimately a call for Vlad/Haley to make 😁

It seems to me that Vlad has noticed an important issue. I don't think this PR adds much value for the user. I'm okay with closing it.

@VladUXUI Please let us know what you think.

VladUXUI · 2023-06-16T08:07:23Z

Yeah, let's close. I think this will add more confusion to user and not enough value. Seeing 0 token assets isn't useful for many people. Also as a user i will rarely add a 0 balance asset just for the fun of it

Karolina Kosiorowska added 2 commits April 26, 2023 14:15

Add custom asset to balances

85f5936

The custom token should be visible in the asset list

4a5858a

* hide assets with balances under $2 * display custom assets when balance is 0

kkosiorowska self-assigned this Apr 26, 2023

kkosiorowska marked this pull request as ready for review April 26, 2023 12:33

kkosiorowska requested review from jagodarybacka, hyphenized and 0xDaedalus April 26, 2023 12:33

jagodarybacka requested changes May 3, 2023

View reviewed changes

kkosiorowska added 2 commits May 8, 2023 09:25

Merge branch 'main' into token-visibility

a208c70

Make conditions for token visibility more clear

0e2567d

hyphenized mentioned this pull request Jun 12, 2023

Add custom asset copy tweak #3325

Closed

Merge branch 'main' of github.com:tahowallet/extension into token-vis…

b295044

…ibility

Asset that is added manually should be always visible

8f4b520

hyphenized reviewed Jun 16, 2023

View reviewed changes

kkosiorowska closed this Jun 16, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make custom tokens visible in the asset list even if they have a balance of zero #3313

Make custom tokens visible in the asset list even if they have a balance of zero #3313

kkosiorowska commented Apr 26, 2023 •

edited by github-actions bot

Loading

jagodarybacka left a comment

jagodarybacka May 3, 2023

kkosiorowska commented May 8, 2023

hyphenized commented May 8, 2023

0xDaedalus commented May 8, 2023

jagodarybacka commented Jun 6, 2023

kkosiorowska commented Jun 6, 2023 •

edited

Loading

VladUXUI commented Jun 14, 2023

kkosiorowska commented Jun 14, 2023 •

edited

Loading

Shadowfiend commented Jun 15, 2023 •

edited

Loading

hyphenized Jun 16, 2023

kkosiorowska commented Jun 16, 2023

VladUXUI commented Jun 16, 2023

Make custom tokens visible in the asset list even if they have a balance of zero #3313

Make custom tokens visible in the asset list even if they have a balance of zero #3313

Conversation

kkosiorowska commented Apr 26, 2023 • edited by github-actions bot Loading

What

UI

To Test

jagodarybacka left a comment

Choose a reason for hiding this comment

jagodarybacka May 3, 2023

Choose a reason for hiding this comment

kkosiorowska commented May 8, 2023

hyphenized commented May 8, 2023

0xDaedalus commented May 8, 2023

jagodarybacka commented Jun 6, 2023

kkosiorowska commented Jun 6, 2023 • edited Loading

VladUXUI commented Jun 14, 2023

kkosiorowska commented Jun 14, 2023 • edited Loading

Shadowfiend commented Jun 15, 2023 • edited Loading

hyphenized Jun 16, 2023

Choose a reason for hiding this comment

kkosiorowska commented Jun 16, 2023

VladUXUI commented Jun 16, 2023

kkosiorowska commented Apr 26, 2023 •

edited by github-actions bot

Loading

kkosiorowska commented Jun 6, 2023 •

edited

Loading

kkosiorowska commented Jun 14, 2023 •

edited

Loading

Shadowfiend commented Jun 15, 2023 •

edited

Loading