Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support video user avatars #3688

Closed
Tracked by #819
jagodarybacka opened this issue Dec 1, 2023 · 0 comments · Fixed by #3700
Closed
Tracked by #819

Support video user avatars #3688

jagodarybacka opened this issue Dec 1, 2023 · 0 comments · Fixed by #3700
Assignees
@xpaczka

Comments

@jagodarybacka
Copy link
Contributor

If user avatar is a video then the wallet doesn't know how to display it correctly (as it assumes that will be an image)
Let's support video avatars as well.

image
@jagodarybacka jagodarybacka mentioned this issue Dec 1, 2023
Open
@xpaczka xpaczka self-assigned this Dec 1, 2023
@xpaczka xpaczka mentioned this issue Dec 14, 2023
Merged
2 tasks
jagodarybacka added a commit that referenced this issue Dec 18, 2023
@jagodarybacka
Support video avatars (#3700)
bb4824c 
Resolves #3688

## What has been done

Added video support for wallet avatars

## Testing
- [x] Test with video avatar (example user
`0xab7375daf14bc661a0c9aff8800d49a34b037a98`)
- [x] Test with image avatar

Latest build:
[extension-builds-3700](https://github.com/tahowallet/extension/suites/19135090954/artifacts/1121162389)
(as of Mon, 18 Dec 2023 11:20:52 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xpaczka xpaczka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support video avatars tahowallet/extension
2 participants
@jagodarybacka @xpaczka