Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show mnemonic menu #3259

Merged
merged 18 commits into from
Apr 11, 2023
Merged

Show mnemonic menu #3259

merged 18 commits into from
Apr 11, 2023

Conversation

jagodarybacka
Copy link
Contributor

@jagodarybacka jagodarybacka commented Apr 6, 2023

What

This PR implements flow of exporting mnemonics.

  • adding menu option and slideup for exporting mnemonics
  • handling both short and long mnemonics

Improvements:

  • code cleanup and improvements
  • fixing small visual bugs
  • making export slideups bigger
  • hiding unnecessary locked wallet snackbar

Testing

  • go through both flows - mnemonic export and private keys export

Known problems

  • the blur over the mnemonic is buggy in chrome, part of the blur that is not initially visible inside the viewport may not be blurred. Will be resolved later.

imageimage

Latest build: extension-builds-3259 (as of Mon, 10 Apr 2023 12:54:22 GMT).

Let's make it obvious which kind of keys import was used for
a given signer.
- add menu option to export mnemonic
- add unstyled panel content
- move ShowMnemonic and ShowPrivateKey slideups to separate folder
- create Explainer component to reuse explainer's styles
@jagodarybacka jagodarybacka added this to the Backup Accounts milestone Apr 6, 2023
@jagodarybacka jagodarybacka self-assigned this Apr 7, 2023
@jagodarybacka jagodarybacka marked this pull request as ready for review April 7, 2023 14:09
@jagodarybacka jagodarybacka requested a review from a team as a code owner April 7, 2023 14:10
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A piece of good work 🤩 I left small thoughts.

ui/components/AccountsBackup/Explainer.tsx Outdated Show resolved Hide resolved
ui/components/AccountsBackup/Explainer.tsx Outdated Show resolved Hide resolved
ui/components/AccountsBackup/Explainer.tsx Show resolved Hide resolved
ui/components/AccountsBackup/RevealMnemonic.tsx Outdated Show resolved Hide resolved
ui/components/AccountsBackup/ShowMnemonic.tsx Outdated Show resolved Hide resolved
ui/components/AccountsBackup/ShowMnemonic.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@kkosiorowska kkosiorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅

@kkosiorowska kkosiorowska merged commit 619111b into show-private-key-menu Apr 11, 2023
@kkosiorowska kkosiorowska deleted the show-mnemonic-menu branch April 11, 2023 06:32
@kkosiorowska kkosiorowska mentioned this pull request Jul 13, 2023
kkosiorowska pushed a commit that referenced this pull request Jul 14, 2023
## What's Changed
* Add private key onboarding flow by @jagodarybacka in
#3119
* Private key JSON import by @jagodarybacka in
#3177
* Allow export of private keys and mnemonics by @jagodarybacka in
#3248
* Export private key form by @jagodarybacka in
#3255
* Unlock screen for the account backup by @kkosiorowska in
#3257
* Show mnemonic menu by @jagodarybacka in
#3259
* Fix background blur issue by @jagodarybacka in
#3265
* Account backup UI fixes by @jagodarybacka in
#3270
* Fix unhiding removed accounts by @jagodarybacka in
#3282
* New error for incorrectly decrypted JSON file by @jagodarybacka in
#3293
* Export private keys from HD wallet addresses by @jagodarybacka in
#3253
* Refactor keyring redux slice to remove `importing` field by
@jagodarybacka in #3309
* 📚 Accounts backup by @kkosiorowska in
#3252
* Catch Enter keypress on Unlock screen by @jagodarybacka in
#3355
* Rename `keyring` to `internal signer` and other improvements by
@jagodarybacka in #3331
* 🗝 QA - Accounts backup and private key import by @jagodarybacka in
#3266
* Remove private key signers if they are replaced by accounts from HD
wallet by @jagodarybacka in
#3377
* RFB 4: One-Off Keyring Design by @Shadowfiend in
#3372
* Copy to clipboard warning by @kkosiorowska in
#3488
* Allow setting custom auto-lock timer by @hyphenized in
#3477
* Use Argon2 for encrypted vaults by @jagodarybacka in
#3502
* 👑 Private keys import and accounts backup by @jagodarybacka in
#3089
* Untrusted assets should not block the addition of custom tokens by
@kkosiorowska in #3491
* Flip updated dApp connections flag by @Shadowfiend in
#3492
* v0.41.0 by @Shadowfiend in
#3531
* Switch to a given network if adding a network that is already added.
by @0xDaedalus in #3154
* Remove waiting for Loading Doggo component in E2E tests by
@jagodarybacka in #3541
* Squeeze content to better fit on Swaps page by @jagodarybacka in
#3542
* Refactor of terms for verified/unverified assets by @kkosiorowska in
#3528
* Fix ChainList styling by @fulldecent in
#3547
* Update release checklist by @jagodarybacka in
#3548
* Fix custom asset price fetching by @hyphenized in
#3508
* Sticky Defaults: Make Taho-as-default replace MetaMask in almost all
cases by @Shadowfiend in
#3546

## New Contributors
* @fulldecent made their first contribution in
#3547

**Full Changelog**:
v0.41.0...v0.42.0

Latest build:
[extension-builds-3549](https://github.com/tahowallet/extension/suites/14268975651/artifacts/801826435)
(as of Thu, 13 Jul 2023 09:51:56 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants