Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change expected account name in NFTs tests to ENS domain #3494

Merged
merged 3 commits into from
Jun 22, 2023
Merged

Change expected account name in NFTs tests to ENS domain #3494

merged 3 commits into from
Jun 22, 2023

Commits on Jun 22, 2023

  1. Change expected account name in NFTs tests to ENS domain 

    We have configured a ENS name for the
`0x6f1b1f1feb01235e15a7962f16c389c7f8218ed6` address. We need to update the
tests to reflect that.
    @michalinacienciala
    michalinacienciala committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    9fadd21 View commit details
    Browse the repository at this point in the history

  2. Parametrize account name 

    We're adding a `const` variable for the account name so that we can reuse
it easily.
    @michalinacienciala
    michalinacienciala committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    b270c29 View commit details
    Browse the repository at this point in the history

  3. Parametrize account-related data and move to utils 

    We're moving the account address and name to `utils`, so that they could be
easily reused in other tests. We're numering the account, as likely there
will be more acounts used in tests (different accounts may be needed for
different purposes).
    @michalinacienciala
    michalinacienciala committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    5821c55 View commit details
    Browse the repository at this point in the history