Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execute E2E tests more frequently #3499

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Execute E2E tests more frequently #3499

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
168d945
Execute E2E tests more frequently
michalinacienciala Jun 23, 2023
e0a8f3e
Comment out the step executing `@slow` tagged tests
michalinacienciala Jun 23, 2023
86305af
Merge branch 'main' into run-e2e-tests-more-frequently
Shadowfiend Jun 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,10 +114,6 @@ jobs:
path-filter:
- '.env.defaults'
e2e-tests:
if: |
github.ref == 'refs/heads/main'
|| contains(github.head_ref, 'e2e')
|| needs.detect-if-flag-changed.outputs.path-filter == 'true'
needs: [build, detect-if-flag-changed]
timeout-minutes: 60
runs-on: ubuntu-latest
Expand All @@ -139,10 +135,21 @@ jobs:
name: extension-builds-${{ github.event.number || github.event.head_commit.id }}
- name: Extract extension
run: unzip -o chrome.zip -d dist/chrome
- name: Run Playwright tests
run: xvfb-run npx playwright test
# Some tests that we have configured in the `e2e-tests` folder may require
# spending funds. Although they're desined to not spend much, with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# spending funds. Although they're desined to not spend much, with
# spending funds. Although they're designed to not spend much, with

# frequent execution that can accumulate. We don't want to execute such
# tests on every PR update. We'll tag those tests with the `@slow` tag.
- name: Run free Playwright tests
run: xvfb-run npx playwright test --grep-invert @slow
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use yarn instead of npx for consistency/simplicity across the repo.

#env:
# DEBUG: pw:api*
# TODO: Uncomment once we have some `@slow` tagged tests in our test set.
# - name: Run costing Playwright tests
# if: |
# github.ref == 'refs/heads/main'
# || contains(github.head_ref, 'e2e')
# || needs.detect-if-flag-changed.outputs.path-filter == 'true'
# run: xvfb-run npx playwright test --grep @slow
- uses: actions/upload-artifact@v3
if: failure()
with:
Expand Down