Fix E2E onboarding helper #3503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Incidentally, you can pass |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under certain conditions, running e2e tests would sometimes open up a third, blank tab which caused an onboarding helper to fail setting the page to run the tests correctly or even executing the test run.
There are a few ways to test this fix addresses the issue:
PWDebug=1 npx playwright test, after opening the browser the tests should run normally (might need to click play button on the playwright debugger).PWDebug=console npx playwright test, after opening the browser the tests should run normally.npx playwright test, tests should also run normallyLatest build: extension-builds-3503 (as of Mon, 26 Jun 2023 22:16:46 GMT).