Fix migration for cleaning account balances #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MIgration should be ready to handle accounts that are in a loading state without throwing and breaking the extension.
|
I think we should be using types from redux slices in the migrations to avoid errors like this that are hard to notice without manually comparing types 🤔 |
kkosiorowska
approved these changes
Jul 5, 2023
|
The problem is the migrations change the types, so to achieve that we'd have to snapshot the types, which is effectively what we're doing here. A little tool that could extract the type from the language server for a given part of the redux store and copy it into the file could make this less error prone however. |
Shadowfiend
added a commit
that referenced
this pull request
Jul 5, 2023
Hotfix version with fix from #3527 Latest build: [extension-builds-3529](https://github.com/tahowallet/extension/suites/14073950651/artifacts/786730313) (as of Wed, 05 Jul 2023 11:12:40 GMT).
Merged
kkosiorowska
pushed a commit
that referenced
this pull request
Jul 10, 2023
## Highlights - An updated Taho token list! This will start auto-updating Soon™. ## What's Changed * Update Taho token list reference by @kkosiorowska in #3506 * Don't run e2e tests when workflow is triggered by push of tag by @michalinacienciala in #3514 * Fix throwing NFT filters panel by @jagodarybacka in #3513 * Use gas price from 0x quote to setup swap transaction by @jagodarybacka in #3516 * v0.40.0 by @hyphenized in #3507 * Add cron job to sync pledge signers by @hyphenized in #3505 * Fix invalid workflow file by @hyphenized in #3519 * Remove workflow trigger used for testing by @hyphenized in #3520 * Fix migration for cleaning account balances by @jagodarybacka in #3527 * v0.40.1 with op swaps gas price hotfix by @Shadowfiend in #3518 * v0.40.2 - accounts migration fix by @jagodarybacka in #3529 **Full Changelog**: v0.40.2...v0.41.0 Latest build: [extension-builds-3531](https://github.com/tahowallet/extension/suites/14093546910/artifacts/788185513) (as of Thu, 06 Jul 2023 02:05:27 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migration should be ready to handle accounts that are in a loading state without throwing and breaking the extension.
Latest build: extension-builds-3527 (as of Wed, 05 Jul 2023 09:15:07 GMT).