Refactor assets slice #3553
Closed
Refactor assets slice #3553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help reduce redundancy after trust checks
Removed symbols from network base asset ids generation, added chain id to ids for all asset types. This allows us to use these for indexing assets across networks in e.g. redux.
Refactored assets slice to an object indexed by asset ids. State updates emitted from the indexing service are diffed and handled faster with this approach.
Properly pass a custom asset to the metadata update test to account for updated reducer logic
hyphenized
force-pushed
the
assets-sliced
branch
from
caf756d
to
40cc6ab
Compare
Comment on lines
+57
to
+58
| // Update verified status, token lists or discovery txs for custom assets | ||
| if (!isBaselineTrustedAsset(existing)) { |
There was a problem hiding this comment.
isBaselineTrustedAsset checks if asset is a base asset or asset from token list. This means that only custom assets should be updated. Why then do we allow updates to property tokenLists. Shouldn't custom assets have this property empty? 🤔
| const pricesState: PricesState = { | ||
| [getFullAssetID(assetWithPricePoint)]: { | ||
| [getFullAssetID(asset)]: { | ||
| USD: pricePoint, | ||
| }, | ||
| } | ||
|
|
||
| describe("Reducers", () => { | ||
| describe("assetsLoaded", () => { | ||
| test("updates cached asset metadata", () => { |
There was a problem hiding this comment.
Non-blocking
I wonder if it wouldn't be good if the description was more specific about what tests do.
Comment on lines
+985
to
+986
| .map(({ value }) => value) | ||
| .flat() |
There was a problem hiding this comment.
Is it possible to use flatMap here?
Comment on lines
+6
to
+24
| export const assets: Record<string, SmartContractFungibleAsset> = | ||
| Object.fromEntries( | ||
| [ | ||
| { | ||
| name: "Wrapped Ether", | ||
| symbol: "WETH", | ||
| decimals: 18, | ||
| homeNetwork: ETHEREUM, | ||
| contractAddress: "0x0", | ||
| }, | ||
| { | ||
| name: "Uniswap", | ||
| symbol: "UNI", | ||
| decimals: 18, | ||
| homeNetwork: ETHEREUM, | ||
| contractAddress: "0x0", | ||
| }, | ||
| ].map((asset) => [getFullAssetID(asset), asset]) | ||
| ) |
There was a problem hiding this comment.
Non-blocking
I wonder why we don't just use createSmartContractAsset here.
|
Closed until reprioritization |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored assets slice to an object indexed by asset ids. State updates emitted from the indexing service are diffed and handled faster with this approach.
Builds on top of #3530 and #3526
To Test
Switch from main to this branch
Latest build: extension-builds-3553 (as of Tue, 18 Jul 2023 18:59:27 GMT).