Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.53.0 #3690

Merged
merged 2 commits into from
Dec 14, 2023
Merged

v0.53.0 #3690

merged 2 commits into from
Dec 14, 2023

Conversation

Shadowfiend
Copy link
Contributor

@Shadowfiend Shadowfiend commented Dec 7, 2023 •
edited by github-actions bot
Loading

What's Changed

New Contributors

Full Changelog: v0.52.0...v0.53.0

Latest build: extension-builds-3690 (as of Thu, 14 Dec 2023 12:54:58 GMT).

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 7, 2023 •
edited by Shadowfiend
Loading

Release checklist

This release checklist should be performed before release is published.

  • dev tests should be performed by the dev team
  • if something is not working please create an issue and link it here. Checkbox should be checked only if everything was fine
  • in case of serious issues or doubts you should ask the team first

Don't forget to approve the PR when checklist is finished ✅

Dev tests

🚀 Version update

  • update from previous version with some accounts loaded

Manual tests

🤖 Items marked with this emoji are good candidates for automation (although
it does not mean that they all would be obsolete once automated).

📨 Add account

  1. Add read-only account with ENS
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities (abilities should not be displayed) 🤖
    • check activities
    • check portfolio page 🤖
    • check export options (export recovery phrase and export private key should not be available) 🤖
  2. Add read-only account with UNS
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities (abilities should not be displayed) 🤖
    • check activities
    • check portfolio page 🤖
    • check export options (export recovery phrase and export private key should not be available) 🤖
  3. Add read-only account with 0x address
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities (abilities should not be displayed) 🤖
    • check activities
    • check portfolio page 🤖
    • check export options (export recovery phrse and export private key should not be available) 🤖
  4. Import account with a seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check seed phrase export
    • check private key export for first account 🤖
  5. Add another account from the same seed phrase
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export for second account 🤖
  6. Add account with a Ledger
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check export options (export recovery phrase and export private key should not be available)
  7. Create new wallet
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities 🤖
    • check activities 🤖
    • check portfolio page 🤖
    • check private key export 🤖
  8. Add account with private key
    • check assets
    • check balance
    • check NFTs
    • check abilities
    • check activities
    • check portfolio page
    • check private key export 🤖
  9. Add account with JSON keystore
    • check assets 🤖
    • check balance 🤖
    • check NFTs 🤖
    • check abilities 🤖
    • check activities 🤖
    • check portfolio page 🤖
    • check private key export 🤖

🗑️ Remove account

  1. Remove account by type
    • remove read-only account 🤖
    • remove address from imported account 🤖
    • remove Ledger account
    • remove account imported with private key 🤖
    • remove account imported with JSON keystore 🤖
    • remove selected account 🤖
    • remove not selected account 🤖
    • remove all accounts 🤖
  2. Remove account and check functionalities
    • add removed address from imported account 🤖
    • remove all addresses from imported account 🤖
    • check if NFTs are removed for removed accounts 🤖
    • check if abilities are removed for removed accounts 🤖
    • check if Portfolio page is updated for removed accounts 🤖

💌 Send base asset

When there are no changes touching sending txs in the release, only one base
asset send transaction on some mainnet chain is required to be tested. Make sure
it's on different chain than the ERC-20 asset send transaction.
When there are changes in the release that may affect transactions, lets test
everything from the list.

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

🎁 Send ERC20

When there are no changes touching sending txs in the release, only one ERC20
send transaction on some mainnet chain is required to be tested. Make sure it's
on different chain than the base asset send transaction.
When there are changes in the release that may affect transactions, lets test
everything from the list.

  1. Ethereum mainnet
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  2. Polygon
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check gas settings and gas price
    • sign
    • check transaction on scan website

💸 Internal swap

When there are no changes touching swaps in the release, only one swap on some
mainnet chain is required to be tested.
When there are changes in the release that may affect swaps, lets test
everything from the list.

  1. Ethereum mainnet
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign (if expensive, can be executed on testnet)
    • check transaction on scan website
  2. Polygon
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  3. Optimism
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  4. Arbitrum
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  5. Avalanche
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website
  6. Binance Smart Chain
    • check token list
    • sign token spend approval
    • check gas settings and gas price
    • sign
    • check transaction on scan website

📡 dApps connections

When there are no changes touching connectivity to dApps, it's enough to do only
a few reandom tests from the list.

🎭 Sign in with Ethereum

🐶 Default wallet

  1. Default wallet setting turned OFF
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using MM
  2. Default wallet setting turned ON
    • connect with dapp without MM available using Taho
    • connect with dapp with MM available using Taho

⚙️ Settings

  • check hide balance under $2 option 🤖
  • check bug reports - export logs 🤖
  • check connected dapp - confirm you are able to disconnect from a dapp and connect again on different network 🤖

☀️ Abilities

  • check each filter option 🤖
  • delete ability 🤖
  • mark ability as completed 🤖

🌠 NFTs page

  1. NFTs page
    • browse NFTs 🤖
    • expand and collapse collection 🤖
    • check NFT preview 🤖
    • check Badges tab 🤖
  2. NFTs filters
    • check each sort type 🤖
    • disable account 🤖
    • disable collection 🤖

🦾 Flashbots

  1. Enable Flashbots in settings:
    • send/swap an asset & confirm trxn on Ethereum shows the Flashbots option with it auto-selected 🤖
    • confirm trxn is then sent through Flashbots 🤖 (send only)
    • send/swap another asset deselect Flashbots option
    • confirm that trxn is not sent through Flashbots 🤖 (send only)
  2. Check trxns on other networks
    • confirm Flashbots checkbox isn't shown at all 🤖
    • confirm trxn is not sent through Flashbots 🤖
  3. Disable Flashbots option in settings
    • send/swap an asset on Ethereum & confirm trxn shows without the Flashbots option 🤖
    • confirm trxn is not sent through Flashbots 🤖 (send only)

jagodarybacka
jagodarybacka approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@jagodarybacka jagodarybacka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chrome review is approved so I'm approving this PR as well, please merge if we are good to publish

@jagodarybacka
Copy link
Contributor

Merging as we already published it

@jagodarybacka jagodarybacka merged commit 99f77e6 into main Dec 14, 2023
6 checks passed
@jagodarybacka jagodarybacka deleted the release-0.53.0 branch December 14, 2023 12:41
@xpaczka xpaczka mentioned this pull request Dec 15, 2023
Merged
xpaczka added a commit that referenced this pull request Dec 22, 2023
@xpaczka
v0.54.0 (#3706)
6c97aef 
## What's Changed
* Hide Subscape features by @jagodarybacka in
#3697
* Add Subscape realms by adddress not name by @jagodarybacka in
#3695
* Create script to export pledge signers by @jagodarybacka in
#3698
* Fix removing custom networks by @jagodarybacka in
#3699
* Disable listeners on realm contract by @jagodarybacka in
#3701
* v0.53.0 by @Shadowfiend in
#3690
* removed typo from removePreferencesForChain func of
intenralEthtereuemProviderClass by @EggsyOnCode in
#3691
* Check DevTools when executing tests on release testlist by
@michalinacienciala in #3704
* v0.53.1 by @jagodarybacka in
#3702

## New Contributors
* @EggsyOnCode made their first contribution in
#3691

**Full Changelog**:
v0.53.1...v0.54.0

Latest build:
[extension-builds-3706](https://github.com/tahowallet/extension/suites/19076409335/artifacts/1117045278)
(as of Fri, 15 Dec 2023 10:58:26 GMT).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jagodarybacka jagodarybacka jagodarybacka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shadowfiend @jagodarybacka